docs: add rum response_headers #5954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
simitt
reviewed
Aug 23, 2021
docs/configuration-rum.asciidoc
Outdated
| Custom HTTP headers to add to RUM responses. | ||
| This can be useful for security policy compliance. | ||
|
|
||
| Any values set in `apm-server.response_headers` also apply to RUM events. |
There was a problem hiding this comment.
I don't quite understand what you mean with this sentence; custom headers are not added to the indexed trace events. Can we just remove this line?
There was a problem hiding this comment.
Sure, I can remove it. This sentence was added based on what I read in #4523 (comment)
If both are defined, then they will both be added to RUM responses, with values for the same key concatenated.
There was a problem hiding this comment.
Suggested change
| Any values set in `apm-server.response_headers` also apply to RUM events. |
bmorelli25
added a commit
to bmorelli25/apm-server
that referenced
this pull request
Aug 23, 2021
bmorelli25
added a commit
to bmorelli25/apm-server
that referenced
this pull request
Aug 23, 2021
bmorelli25
added a commit
to bmorelli25/apm-server
that referenced
this pull request
Aug 23, 2021
bmorelli25
added a commit
that referenced
this pull request
Aug 23, 2021
bmorelli25
added a commit
that referenced
this pull request
Aug 23, 2021
bmorelli25
added a commit
that referenced
this pull request
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Docs
apm-server.rum.response_headers.Related issues
apm-server.response_headers)