Update tail sampling to require data streams #5952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tail-sampling now requires data streams to be enabled, and apm-server will error if tail-sampling is enabled and data streams are not. The code for creating a sampled traces data stream when running in standalone has been removed. The data stream is now expected to be created by installing the integration package. Rename the sampled traces data stream from `traces-sampled-*` to `traces-apm.sampled-*`, to maintain a common "apm" prefix for all datasets. The Elasticsearch role used by apm-server in tests has been updated with access to `traces-apm*`, `metrics-apm*`, and `logs-apm*`.
axw
force-pushed
the
tail-sampling-data-streams
branch
from
1d512d4 to
26e23fd
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
simitt
approved these changes
Aug 18, 2021
2 tasks
mergify bot
pushed a commit
that referenced
this pull request
Aug 18, 2021
* Update tail sampling to require data streams Tail-sampling now requires data streams to be enabled, and apm-server will error if tail-sampling is enabled and data streams are not. The code for creating a sampled traces data stream when running in standalone has been removed. The data stream is now expected to be created by installing the integration package. Rename the sampled traces data stream from `traces-sampled-*` to `traces-apm.sampled-*`, to maintain a common "apm" prefix for all datasets. The Elasticsearch role used by apm-server in tests has been updated with access to `traces-apm*`, `metrics-apm*`, and `logs-apm*`. * systemtest: fix TestTailSamplingUnlicensed * Update changelog (cherry picked from commit 2c65c70) # Conflicts: # changelogs/head.asciidoc
axw
added a commit
that referenced
this pull request
Aug 18, 2021
…5964) * Update tail sampling to require data streams (#5952) * Update tail sampling to require data streams Tail-sampling now requires data streams to be enabled, and apm-server will error if tail-sampling is enabled and data streams are not. The code for creating a sampled traces data stream when running in standalone has been removed. The data stream is now expected to be created by installing the integration package. Rename the sampled traces data stream from `traces-sampled-*` to `traces-apm.sampled-*`, to maintain a common "apm" prefix for all datasets. The Elasticsearch role used by apm-server in tests has been updated with access to `traces-apm*`, `metrics-apm*`, and `logs-apm*`. * systemtest: fix TestTailSamplingUnlicensed * Update changelog (cherry picked from commit 2c65c70) # Conflicts: # changelogs/head.asciidoc * Delete head.asciidoc Co-authored-by: Andrew Wilkins <[email protected]>
|
confirmed with bc3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Tail-sampling now requires data streams to be enabled, and apm-server will error if tail-sampling is enabled and data streams are not. The code for creating a sampled traces data stream when running in standalone has been removed. The data stream is now expected to be created by installing the integration package.
Rename the sampled traces data stream from
traces-sampled-*totraces-apm.sampled-*, to maintain a common "apm" prefix for all datasets. The Elasticsearch role used by apm-server in tests has been updated with access totraces-apm*,metrics-apm*, andlogs-apm*; similar to elastic/elasticsearch#68749.Checklist
- [ ] Documentation has been updatedHow to test these changes
Related issues
Closes #5125