aggregation/spanmetrics: handle composite spans #5896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update spanmetrics to take into account composite spans, multiplying the span count by the composite count and using the reported composite span duration instead of the "gross" duration.
axw
force-pushed
the
compressed-spans-metrics
branch
from
7d7c900 to
b2099c5
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
stuartnelson3
approved these changes
Aug 5, 2021
mergify bot
pushed a commit
that referenced
this pull request
Aug 8, 2021
Update spanmetrics to take into account composite spans, multiplying the span count by the composite count and using the reported composite span duration instead of the "gross" duration. (cherry picked from commit b1bf67d) # Conflicts: # changelogs/head.asciidoc
axw
added a commit
that referenced
this pull request
Aug 8, 2021
#5904) * aggregation/spanmetrics: handle composite spans (#5896) Update spanmetrics to take into account composite spans, multiplying the span count by the composite count and using the reported composite span duration instead of the "gross" duration. (cherry picked from commit b1bf67d) # Conflicts: # changelogs/head.asciidoc * Delete head.asciidoc * make update Co-authored-by: Andrew Wilkins <[email protected]>
|
Confirmed with BC2, in conjunction with #5661 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Update spanmetrics to take into account composite spans, using the composite span count and duration. Like non-composite spans, these are also multiplied by the "representative count", i.e. the inverse sampling ratio.
Checklist
- [ ] Documentation has been updatedHow to test these changes
Related issues
Closes #5595