Remove sourcemap/test and elasticsearch/estest #5854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearch/estest was only used inside the sourcemap package's tests. Remove this package and refactor tests to use an httptest.Server where feasible. Change the beater test that was using sourcemap/test for test data to use the sourcemap in testdata/sourcemap instead, and remove sourcemap/test.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
mergify bot
pushed a commit
that referenced
this pull request
Aug 2, 2021
elasticsearch/estest was only used inside the sourcemap package's tests. Remove this package and refactor tests to use an httptest.Server where feasible. Change the beater test that was using sourcemap/test for test data to use the sourcemap in testdata/sourcemap instead, and remove sourcemap/test. (cherry picked from commit 7ccc202) # Conflicts: # elasticsearch/estest/client.go
axw
added a commit
that referenced
this pull request
Aug 3, 2021
elasticsearch/estest was only used inside the sourcemap package's tests. Remove this package and refactor tests to use an httptest.Server where feasible. Change the beater test that was using sourcemap/test for test data to use the sourcemap in testdata/sourcemap instead, and remove sourcemap/test. (cherry picked from commit 7ccc202)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Remove unnecessarily fragmented packages used for testing source maps, moving the code directly into the sourcemap package:
Checklist
- [ ] Update CHANGELOG.asciidoc- [ ] Documentation has been updatedHow to test these changes
Non-functional change.
Related issues
Yak shaving related to cherry-picking go-elasticsearch product check changes into #5838