sourcemap: fix data race in test #5842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix data race in TestFleetFetch: as there are two servers, one may update hasAuth concurrently with the test checking the value. Change the way the auth header is checked to be similar to how the header would be checked in a real fleet-server, and respond with 401 if the auth header is invalid.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
stuartnelson3
approved these changes
Aug 2, 2021
mergify bot
pushed a commit
that referenced
this pull request
Aug 2, 2021
Fix data race in TestFleetFetch: as there are two servers, one may update hasAuth concurrently with the test checking the value. Change the way the auth header is checked to be similar to how the header would be checked in a real fleet-server, and respond with 401 if the auth header is invalid. (cherry picked from commit 710d4ed) # Conflicts: # sourcemap/fleet_store_test.go
axw
added a commit
to axw/apm-server
that referenced
this pull request
Aug 2, 2021
Fix data race in TestFleetFetch: as there are two servers, one may update hasAuth concurrently with the test checking the value. Change the way the auth header is checked to be similar to how the header would be checked in a real fleet-server, and respond with 401 if the auth header is invalid.
axw
added a commit
that referenced
this pull request
Aug 3, 2021
Fix data race in TestFleetFetch: as there are two servers, one may update hasAuth concurrently with the test checking the value. Change the way the auth header is checked to be similar to how the header would be checked in a real fleet-server, and respond with 401 if the auth header is invalid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Fix data race in TestFleetFetch: as there are two servers, one may update hasAuth concurrently with the test checking the value.
Change the way the auth header is checked to be similar to how the header would be checked in a real fleet-server, and respond with 401 if the auth header is invalid. Since we wait for a valid response, we can be sure the header has been checked.
Checklist
- [ ] Update CHANGELOG.asciidoc- [ ] Documentation has been updatedHow to test these changes
go test -v -race -count=50 -failfast -run TestFleetFetchRelated issues
https://apm-ci.elastic.co/blue/organizations/jenkins/apm-server%2Fapm-server-mbp/detail/PR-5840/2/tests/