Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-beats: git add fields updates #5835

Merged
merged 1 commit into from
Aug 2, 2021
Merged

Conversation

axw
Copy link
Member

@axw axw commented Jul 30, 2021

Motivation/summary

When running make update-beats, it is possible for fields to change. When this happens, we'll need to git add the following additional files:

  • include/fields.go
  • x-pack/apm-server/fields.go
  • docs/fields.asciidoc

See #5834

Checklist

- [ ] Update CHANGELOG.asciidoc
- [ ] Documentation has been updated

How to test these changes

N/A

Related issues

None

@axw axw requested a review from v1v July 30, 2021 07:49
@apmmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-07-30T07:49:58.808+0000

  • Duration: 38 min 31 sec

  • Commit: 25105f5

Test stats 🧪

Test Results
Failed 0
Passed 5970
Skipped 14
Total 5984

Trends 🧪

Image of Build Times

Image of Tests

@axw axw merged commit 2e1dc7b into elastic:master Aug 2, 2021
@axw axw deleted the update-beats-fields branch August 2, 2021 01:15
mergify bot pushed a commit that referenced this pull request Aug 2, 2021
axw added a commit that referenced this pull request Aug 2, 2021
(cherry picked from commit 2e1dc7b)

Co-authored-by: Andrew Wilkins <[email protected]>
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants