Remove model.Metadata, fold into model.APMEvent #5830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finally, fold model.Metadata's fields directly into model.APMEvent, remove the model.Metadata type, and adapt ~the entire codebase. The MetadataProcessorFunc batch processor has been removed, as model processors that need to act on the common fields can do so without switching on event- specific fields.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
stuartnelson3
approved these changes
Jul 30, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jul 31, 2021
Finally, fold model.Metadata's fields directly into model.APMEvent, remove the model.Metadata type, and adapt ~the entire codebase. The MetadataProcessorFunc batch processor has been removed, as model processors that need to act on the common fields can do so without switching on event- specific fields. (cherry picked from commit 9d32ab9)
axw
added a commit
that referenced
this pull request
Aug 2, 2021
Finally, fold model.Metadata's fields directly into model.APMEvent, remove the model.Metadata type, and adapt ~the entire codebase. The MetadataProcessorFunc batch processor has been removed, as model processors that need to act on the common fields can do so without switching on event- specific fields. (cherry picked from commit 9d32ab9) Co-authored-by: Andrew Wilkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Fold model.Metadata's fields directly into
model.APMEvent, remove themodel.Metadatatype. Another step to making the model types look the resulting Elasticsearch docs.The
modelprocessor.MetadataProcessorFuncbatch processor has been removed, as model processors that need to act on the common fields can do so without switching on event-specific fields.modeldecoder.Inputnow contains amodel.APMEventwhich serves as the base for any decoded events: each event will take a copy of the Base value, and merge the decoded, event-specific, fields with it.This PR is otherwise fairly mechanical in updating code to refer to reference the new
model.APMEventfields instead ofmodel.Metadatafields embedded within event-specific types.Checklist
- [ ] Update CHANGELOG.asciidoc- [ ] Documentation has been updatedHow to test these changes
Non-functional change.
Related issues
#4120
#3565