sammpling: refactor to read/write model.APMEvents #5814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the tail-based sampling package to read and write model.APMEvents, rather than model.Transactions and model.Spans. This is in preparation for moving "metadata" up to APMEvent.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
stuartnelson3
approved these changes
Jul 29, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jul 29, 2021
Update the tail-based sampling package to read and write model.APMEvents, rather than model.Transactions and model.Spans. This is in preparation for moving "metadata" up to APMEvent. (cherry picked from commit 96d24d4)
axw
added a commit
that referenced
this pull request
Jul 29, 2021
Update the tail-based sampling package to read and write model.APMEvents, rather than model.Transactions and model.Spans. This is in preparation for moving "metadata" up to APMEvent. (cherry picked from commit 96d24d4) Co-authored-by: Andrew Wilkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Update the tail-based sampling package to read and write model.APMEvents, rather than model.Transactions and model.Spans.
This is in preparation for moving "metadata" up to APMEvent.
There is a breaking change to the tail-based sampling event storage: the "meta" byte used for identifying trace events is 'e', where we previously used 'T' for transactions and 'S' for spans. This feature is not yet GA, is not yet documented, and there will be further breaking changes; hence it is not highlighted in the changelog.
Checklist
- [ ] Update CHANGELOG.asciidoc- [ ] Documentation has been updatedHow to test these changes
N/A
Related issues
#4120