Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create our own glog replacement #5809

Merged
merged 2 commits into from
Jul 28, 2021
Merged

Create our own glog replacement #5809

merged 2 commits into from
Jul 28, 2021

Conversation

axw
Copy link
Member

@axw axw commented Jul 27, 2021

Motivation/summary

The replacement module we were using causes issues with go mod tidy due to it having a different module path. This was causing go mod tidy to fail with errors like:

07:04:10 go: finding module for package github.com/slok/noglog
07:04:10 go: found github.com/slok/noglog in github.com/slok/noglog v0.2.0
07:04:10 go: github.com/slok/[email protected] used for two different module paths (github.com/golang/glog and github.com/slok/noglog)
07:04:10 Makefile:193: recipe for target 'update-beats-module' failed
07:04:10 make: *** [update-beats-module] Error 1

I've created a minimal glog replacement under internal/glog with the same module path and package name as github.com/golang/glog to resolve this.

Checklist

- [ ] Update CHANGELOG.asciidoc
- [ ] Documentation has been updated

How to test these changes

go mod tidy shouldn't fail

Related issues

None.

@axw axw requested a review from a team July 27, 2021 13:01
@apmmachine
Copy link
Contributor

apmmachine commented Jul 27, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-07-28T00:41:26.641+0000

  • Duration: 39 min 39 sec

  • Commit: 894867c

Test stats 🧪

Test Results
Failed 0
Passed 5965
Skipped 14
Total 5979

Trends 🧪

Image of Build Times

Image of Tests

@axw axw merged commit 7a5fc06 into elastic:master Jul 28, 2021
@axw axw deleted the fix-noglog branch July 28, 2021 01:21
mergify bot pushed a commit that referenced this pull request Jul 28, 2021
* Create our own glog replacement

* Fix system tests

(cherry picked from commit 7a5fc06)

# Conflicts:
#	.gitignore
#	NOTICE.txt
#	go.sum
axw added a commit that referenced this pull request Jul 28, 2021
* Create our own glog replacement (#5809)

* Create our own glog replacement

* Fix system tests

(cherry picked from commit 7a5fc06)

# Conflicts:
#	.gitignore
#	NOTICE.txt
#	go.sum

* Fix merge conflicts

Co-authored-by: Andrew Wilkins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants