Move model value normalisation to modeldecoder #5784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When modeldecoder decodes numbers and stores them
in interface{} fields, it has been storing them as
json.Numbers and we would convert these to numbers
during model transformation. As this is specific to
modeldecoder and not any other inputs (e.g. OTLP),
move this "normalisation" logic to modeldecoder.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
stuartnelson3
approved these changes
Jul 22, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jul 23, 2021
When modeldecoder decodes numbers and stores them
in interface{} fields, it has been storing them as
json.Numbers and we would convert these to numbers
during model transformation. As this is specific to
modeldecoder and not any other inputs (e.g. OTLP),
move this "normalisation" logic to modeldecoder.
(cherry picked from commit 6211be6)
axw
added a commit
that referenced
this pull request
Jul 26, 2021
When modeldecoder decodes numbers and stores them
in interface{} fields, it has been storing them as
json.Numbers and we would convert these to numbers
during model transformation. As this is specific to
modeldecoder and not any other inputs (e.g. OTLP),
move this "normalisation" logic to modeldecoder.
(cherry picked from commit 6211be6)
Co-authored-by: Andrew Wilkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
When modeldecoder decodes numbers and stores them in
interface{}fields, it has been storing them asjson.Numbersand we would later convert these to numbers during model transformation. As this logic is specific to howmodeldecoderdecodes, and not to any other inputs (e.g. OTLP), move this "normalisation" logic tomodeldecoder.Checklist
- [ ] Update CHANGELOG.asciidoc- [ ] Documentation has been updatedHow to test these changes
Non-functional change.
Related issues
#4120
#3565