Consolidate model.HTTP and model.Http #5764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Test errors
Expand to view the tests failures
|
axw
force-pushed
the
model-http
branch
4 times, most recently
from
7fc9f47 to
fca45f9
Compare
For a long time we have had two distinct types, model.HTTP and model.Http, for span (outgoing) and transaction (incoming) HTTP fields. Consolidate these two into one type, to simplify the model and transformation to documents. There is a minor change in precedence for handling context.http.status_code and context.http.response.status_code. This should not matter; the values should be the same, and if they're not then that's on the agent.
stuartnelson3
approved these changes
Jul 20, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jul 21, 2021
For a long time we have had two distinct types, model.HTTP and model.Http, for span (outgoing) and transaction (incoming) HTTP fields. Consolidate these two into one type, to simplify the model and transformation to documents. There is a minor change in precedence for handling context.http.status_code and context.http.response.status_code. This should not matter; the values should be the same, and if they're not then that's on the agent. (cherry picked from commit 46f214e)
axw
added a commit
that referenced
this pull request
Jul 21, 2021
For a long time we have had two distinct types, model.HTTP and model.Http, for span (outgoing) and transaction (incoming) HTTP fields. Consolidate these two into one type, to simplify the model and transformation to documents. There is a minor change in precedence for handling context.http.status_code and context.http.response.status_code. This should not matter; the values should be the same, and if they're not then that's on the agent. (cherry picked from commit 46f214e) Co-authored-by: Andrew Wilkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
For a long time we have had two distinct types, model.HTTP and model.Http, for span (outgoing) and transaction (incoming) HTTP fields. Many of the fields in these types are common. Consolidate into one type to simplify the model and transformation to documents.
There is a minor change in precedence for handling context.http.status_code and context.http.response.status_code. This should not matter; the values should be the same, and if they're not then that's on the agent.
Checklist
- [ ] Update CHANGELOG.asciidoc- [ ] Documentation has been updatedHow to test these changes
Non-functional change.
Related issues
#4120
#3565