Move setting of data_stream fields to processor #5717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
|
/test |
|
This pull request is now in conflicts. Could you fix it @axw? 🙏 |
|
Moving this back into draft while I fix conflicts will do that in a follow up |
simitt
approved these changes
Jul 15, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jul 15, 2021
(cherry picked from commit 29cfed3) # Conflicts: # beater/beater.go # model/apmevent.go # model/error_test.go # model/metricset.go # model/metricset_test.go # model/profile.go # model/profile_test.go # model/span_test.go # model/transaction.go # model/transaction_test.go # transform/transform.go
|
@Mergifyio backport 7.x |
|
Command
|
axw
added a commit
to axw/apm-server
that referenced
this pull request
Jul 15, 2021
axw
added a commit
that referenced
this pull request
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Move the logic associated with setting data_stream fields out of model, into a model processor. Most of our tests will not run the model processor, hence why the data_stream fields disappear from approvals. Importantly, the TestFleetIntegration system test's approval file (which doesn't and shouldn't show up in the diff) retains the fields.
Checklist
- [ ] Update CHANGELOG.asciidoc- [ ] Documentation has been updatedHow to test these changes
Non-functional change.
Related issues
#4410
#4120
#3565