Move setting of destination.ip to ingest pipeline #5695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
simitt
approved these changes
Jul 14, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jul 14, 2021
* Move setting of destination.ip to ingest pipeline * make update * update approvals, fix test (cherry picked from commit 4ed2761)
axw
added a commit
that referenced
this pull request
Jul 14, 2021
* Move setting of destination.ip to ingest pipeline * make update * update approvals, fix test (cherry picked from commit 4ed2761) Co-authored-by: Andrew Wilkins <[email protected]>
|
Confirmed with BC2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
For spans, we copy
destination.addresstodestination.ipif the value is a valid IPv4 or IPv6 address. Move this from model transformation to the Elasticsearch ingest pipeline, to remove logic from model transformation code.Checklist
- [ ] Update CHANGELOG.asciidoc- [ ] Documentation has been updatedHow to test these changes
Send some spans to APM Server with destination address set, and check that
destination.addressis copied (or not) todestination.ipdepending on whether it is a valid IPv4 or IPv6 address.Related issues
#3565