sourcemap: fix flaky test #5581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was failing because the dial attempt would sometimes timeout and return a different error. Change the test to first wait for the request to be received by the server, and then check that context cancellation is honoured. We do this by explicitly cancelling the context, rather than using a timeout.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
simitt
approved these changes
Jun 30, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jun 30, 2021
The test was failing because the dial attempt would sometimes timeout and return a different error. Change the test to first wait for the request to be received by the server, and then check that context cancellation is honoured. We do this by explicitly cancelling the context, rather than using a timeout. (cherry picked from commit 062cb9c)
axw
added a commit
that referenced
this pull request
Jun 30, 2021
The test was failing because the dial attempt would sometimes timeout and return a different error. Change the test to first wait for the request to be received by the server, and then check that context cancellation is honoured. We do this by explicitly cancelling the context, rather than using a timeout. (cherry picked from commit 062cb9c) Co-authored-by: Andrew Wilkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
The test was failing because the dial attempt would
sometimes timeout and return a different error.
Change the test to first wait for the request to be
received by the server, and then check that context
cancellation is honoured. We do this by explicitly
cancelling the context, rather than using a timeout.
Closes #5549