-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config is now rooted under "schema" key #5544
Merged
stuartnelson3
merged 2 commits into
elastic:master
from
stuartnelson3:kibana-apm-config-key-update
Jun 28, 2021
Merged
config is now rooted under "schema" key #5544
stuartnelson3
merged 2 commits into
elastic:master
from
stuartnelson3:kibana-apm-config-key-update
Jun 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
axw
approved these changes
Jun 28, 2021
/test |
mergify bot
pushed a commit
that referenced
this pull request
Jun 28, 2021
(cherry picked from commit 9081652)
stuartnelson3
added a commit
that referenced
this pull request
Jun 28, 2021
(cherry picked from commit 9081652) Co-authored-by: stuart nelson <[email protected]>
2 tasks
Yes they are covering the same, removing the test label from this one. |
mergify bot
pushed a commit
that referenced
this pull request
Jul 9, 2021
(cherry picked from commit 9081652) # Conflicts: # kibana/send_config_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the key under which the apm-server is serialized when sent to kibana.
cc @ogupte
How to test these changes
Note: This pr supersedes changes originally introduced in #5481. The format listed above is, at the time of writing, the correct format for sending the config to kibana.
Running apm-server under fleet, start an agent that requests its config from apm-server. Update the config, and verify that the timeseries has been ingested into elasticsearch.