Introduce shared gRPC authorization interceptor #5515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new gRPC authorization interceptor which is used for both OTLP and Jaeger. This new interceptor dispatches to method-specific handlers. All OTLP methods use the "authorization" metadata, whereas Jaeger has different approaches depending on the method: extract process tags for PostSpans, and anonymous auth only for GetSamplingStrategy.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
The response error message has changed, update the test to expect the new one.
simitt
approved these changes
Jun 22, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jun 23, 2021
* Introduce shared gRPC authorization interceptor Introduce a new gRPC authorization interceptor which is used for both OTLP and Jaeger. This new interceptor dispatches to method-specific handlers. All OTLP methods use the "authorization" metadata, whereas Jaeger has different approaches depending on the method: extract process tags for PostSpans, and anonymous auth only for GetSamplingStrategy. * beater/otlp: revert metrics change * tests/system: update Jaeger system test The response error message has changed, update the test to expect the new one. * beater/jaeger: fix logger name (cherry picked from commit 92335c5)
axw
added a commit
that referenced
this pull request
Jun 23, 2021
* Introduce shared gRPC authorization interceptor Introduce a new gRPC authorization interceptor which is used for both OTLP and Jaeger. This new interceptor dispatches to method-specific handlers. All OTLP methods use the "authorization" metadata, whereas Jaeger has different approaches depending on the method: extract process tags for PostSpans, and anonymous auth only for GetSamplingStrategy. * beater/otlp: revert metrics change * tests/system: update Jaeger system test The response error message has changed, update the test to expect the new one. * beater/jaeger: fix logger name (cherry picked from commit 92335c5) Co-authored-by: Andrew Wilkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Introduce a new gRPC authorization interceptor which is used for both OTLP and Jaeger. This pulls authorization up to the interceptor level, and out of individual methods (in the case of Jaeger). This will enable us to introduce another interceptor for rate limiting anonymous agents.
The new authorization interceptor dispatches to method-specific handlers. All OTLP methods use the "authorization" metadata approach, whereas Jaeger has different approaches depending on the method: extract process tags for PostSpans, and anonymous auth only for GetSamplingStrategy.
How to test these changes
Non-functional change.
Related issues
#5347