Move rate limiting and service name restrictions out of processor/stream #5492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and into beater/api/intake, injected into the stream processor as a batch processor. This paves the way for taking a similar approach for otel.
Unexport some things that are no longer needed for tests.
... and into beater/api, injected into the stream processor as a batch processor. This paves the way for taking a similar approach for otel.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
simitt
approved these changes
Jun 18, 2021
Rate limit after reading but before processing. Simpler and in line with what we will do for OTel.
simitt
approved these changes
Jun 18, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jun 19, 2021
…eam (#5492) * Move rate-limiting out of processor/stream ... and into beater/api/intake, injected into the stream processor as a batch processor. This paves the way for taking a similar approach for otel. * processor/stream: unexport some things Unexport some things that are no longer needed for tests. * Move allowed service names out of processor/stream ... and into beater/api, injected into the stream processor as a batch processor. This paves the way for taking a similar approach for otel. * beater/api/intake: revise rate-limiting Rate limit after reading but before processing. Simpler and in line with what we will do for OTel. * Remove stale comment * Reinstate initial Allow * beater/api/intake: add missing return (cherry picked from commit f5664d8)
axw
added a commit
that referenced
this pull request
Jun 20, 2021
…eam (#5492) (#5497) * Move rate-limiting out of processor/stream ... and into beater/api/intake, injected into the stream processor as a batch processor. This paves the way for taking a similar approach for otel. * processor/stream: unexport some things Unexport some things that are no longer needed for tests. * Move allowed service names out of processor/stream ... and into beater/api, injected into the stream processor as a batch processor. This paves the way for taking a similar approach for otel. * beater/api/intake: revise rate-limiting Rate limit after reading but before processing. Simpler and in line with what we will do for OTel. * Remove stale comment * Reinstate initial Allow * beater/api/intake: add missing return (cherry picked from commit f5664d8) Co-authored-by: Andrew Wilkins <[email protected]>
stuartnelson3
pushed a commit
to stuartnelson3/apm-server
that referenced
this pull request
Jun 22, 2021
…eam (elastic#5492) * Move rate-limiting out of processor/stream ... and into beater/api/intake, injected into the stream processor as a batch processor. This paves the way for taking a similar approach for otel. * processor/stream: unexport some things Unexport some things that are no longer needed for tests. * Move allowed service names out of processor/stream ... and into beater/api, injected into the stream processor as a batch processor. This paves the way for taking a similar approach for otel. * beater/api/intake: revise rate-limiting Rate limit after reading but before processing. Simpler and in line with what we will do for OTel. * Remove stale comment * Reinstate initial Allow * beater/api/intake: add missing return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Move rate limiting and service name restrictions out of processor/stream, up into
beater/api. These are cross-cutting, and separating them out means we both simplify processor/stream and make progress towards making the logic reusable for processor/otel.How to test these changes
Non-functional change.
Related issues
Part of #5347