[cloud] default to medium compression #5446

simitt · 2021-06-14T09:20:47Z

Motivation/summary

Set medium compression level (5) on cloud to retain current behavior when switching to apm server integration.

How to test these changes

run CLOUD_APM_CAPACITY=1024 ./apm-server export config and check that no output.elasticsearch.compression_level is set
run CLOUD_APM_CAPACITY=1024 ./apm-server export config and check that output.elasticsearch.compression_level is set to 5

Set compression level to 5 on cloud.

apmmachine · 2021-06-14T09:59:02Z

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: simitt commented: /test
Start Time: 2021-06-16T08:54:31.129+0000
Duration: 68 min 25 sec
Commit: 25643b1

Test stats 🧪

Test	Results
Failed	1
Passed	6081
Skipped	120
Total	6202

Trends 🧪

Test errors

Expand to view the tests failures

`Build and Test / Unit Test / TestSubscribeSampledTraceIDs – pubsub`

Expand to view the error details

 Failed

Expand to view the stacktrace

 2021/06/16 09:12:41 http: superfluous response.WriteHeader call from github.com/elastic/apm-server/x-pack/apm-server/sampling/pubsub_test.(*requestResponseWriter).WriteStatus (pubsub_test.go:420)
==================
WARNING: DATA RACE
Read at 0x00c0000e0690 by goroutine 53:
  net/http.(*response).write()
      /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/.gvm/versions/go1.16.4.linux.amd64/src/net/http/server.go:1611 +0x4bd
  net/http.(*response).Write()
      /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/.gvm/versions/go1.16.4.linux.amd64/src/net/http/server.go:1573 +0x70
  github.com/elastic/apm-server/x-pack/apm-server/sampling/pubsub_test.(*requestResponseWriter).WriteStatus()
      /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/src/github.com/elastic/apm-server/x-pack/apm-server/sampling/pubsub/pubsub_test.go:421 +0xed
  github.com/elastic/apm-server/x-pack/apm-server/sampling/pubsub_test.(*requestResponseWriter).Write()
      /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/src/github.com/elastic/apm-server/x-pack/apm-server/sampling/pubsub/pubsub_test.go:416 +0xb6a
  github.com/elastic/apm-server/x-pack/apm-server/sampling/pubsub_test.TestSubscribeSampledTraceIDs()
      /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/src/github.com/elastic/apm-server/x-pack/apm-server/sampling/pubsub/pubsub_test.go:252 +0xaf0
  testing.tRunner()
      /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/.gvm/versions/go1.16.4.linux.amd64/src/testing/testing.go:1193 +0x202

Previous write at 0x00c0000e0690 by goroutine 62:
  net/http.(*chunkWriter).writeHeader()
      /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/.gvm/versions/go1.16.4.linux.amd64/src/net/http/server.go:1292 +0x5ea
  net/http.(*chunkWriter).close()
      /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/.gvm/versions/go1.16.4.linux.amd64/src/net/http/server.go:402 +0x188
  net/http.(*response).finishRequest()
      /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/.gvm/versions/go1.16.4.linux.amd64/src/net/http/server.go:1630 +0xc9
  net/http.(*conn).serve()
      /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/.gvm/versions/go1.16.4.linux.amd64/src/net/http/server.go:1957 +0x8d6

Goroutine 53 (running) created at:
  testing.(*T).Run()
      /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/.gvm/versions/go1.16.4.linux.amd64/src/testing/testing.go:1238 +0x5d7
  testing.runTests.func1()
      /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/.gvm/versions/go1.16.4.linux.amd64/src/testing/testing.go:1511 +0xa6
  testing.tRunner()
      /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/.gvm/versions/go1.16.4.linux.amd64/src/testing/testing.go:1193 +0x202
  testing.runTests()
      /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/.gvm/versions/go1.16.4.linux.amd64/src/testing/testing.go:1509 +0x612
  testing.(*M).Run()
      /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/.gvm/versions/go1.16.4.linux.amd64/src/testing/testing.go:1417 +0x3b3
  main.main()
      _testmain.go:111 +0x356

Goroutine 62 (running) created at:
  net/http.(*Server).Serve()
      /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/.gvm/versions/go1.16.4.linux.amd64/src/net/http/server.go:3013 +0x644
  net/http/httptest.(*Server).goServe.func1()
      /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/.gvm/versions/go1.16.4.linux.amd64/src/net/http/httptest/server.go:308 +0xd8
==================
==================
WARNING: DATA RACE
Read at 0x00c0000e0688 by goroutine 62:
  net/http.(*response).shouldReuseConnection()
      /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/.gvm/versions/go1.16.4.linux.amd64/src/net/http/server.go:1654 +0x1b0
  net/http.(*conn).serve()
      /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/.gvm/versions/go1.16.4.linux.amd64/src/net/http/server.go:1958 +0x8e7

Previous write at 0x00c0000e0688 by goroutine 53:
  net/http.(*response).write()
      /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/.gvm/versions/go1.16.4.linux.amd64/src/net/http/server.go:1610 +0x48c
  net/http.(*response).Write()
      /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/.gvm/versions/go1.16.4.linux.amd64/src/net/http/server.go:1573 +0x70
  github.com/elastic/apm-server/x-pack/apm-server/sampling/pubsub_test.(*requestResponseWriter).WriteStatus()
      /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/src/github.com/elastic/apm-server/x-pack/apm-server/sampling/pubsub/pubsub_test.go:421 +0xed
  github.com/elastic/apm-server/x-pack/apm-server/sampling/pubsub_test.(*requestResponseWriter).Write()
      /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/src/github.com/elastic/apm-server/x-pack/apm-server/sampling/pubsub/pubsub_test.go:416 +0xb6a
  github.com/elastic/apm-server/x-pack/apm-server/sampling/pubsub_test.TestSubscribeSampledTraceIDs()
      /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/src/github.com/elastic/apm-server/x-pack/apm-server/sampling/pubsub/pubsub_test.go:252 +0xaf0
  testing.tRunner()
      /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/.gvm/versions/go1.16.4.linux.amd64/src/testing/testing.go:1193 +0x202

Goroutine 62 (running) created at:
  net/http.(*Server).Serve()
      /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/.gvm/versions/go1.16.4.linux.amd64/src/net/http/server.go:3013 +0x644
  net/http/httptest.(*Server).goServe.func1()
      /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/.gvm/versions/go1.16.4.linux.amd64/src/net/http/httptest/server.go:308 +0xd8

Goroutine 53 (running) created at:
  testing.(*T).Run()
      /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/.gvm/versions/go1.16.4.linux.amd64/src/testing/testing.go:1238 +0x5d7
  testing.runTests.func1()
      /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/.gvm/versions/go1.16.4.linux.amd64/src/testing/testing.go:1511 +0xa6
  testing.tRunner()
      /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/.gvm/versions/go1.16.4.linux.amd64/src/testing/testing.go:1193 +0x202
  testing.runTests()
      /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/.gvm/versions/go1.16.4.linux.amd64/src/testing/testing.go:1509 +0x612
  testing.(*M).Run()
      /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/.gvm/versions/go1.16.4.linux.amd64/src/testing/testing.go:1417 +0x3b3
  main.main()
      _testmain.go:111 +0x356
==================
    testing.go:1092: race detected during execution of test

Steps errors

Expand to view the steps failures

`Test Sync`

Took 3 min 20 sec . View more details on here
Description: ./.ci/scripts/sync.sh

Log output

Expand to view the last 100 lines of log output

[2021-06-16T09:29:55.766Z] --- PASS: TestJaegerGRPCMuxedTLS (3.52s)
[2021-06-16T09:29:55.766Z] === RUN   TestJaegerGRPCSampling
[2021-06-16T09:29:55.766Z] --- PASS: TestJaegerGRPCSampling (4.84s)
[2021-06-16T09:29:55.766Z] === RUN   TestJaegerGRPCAuth
[2021-06-16T09:29:55.766Z] --- PASS: TestJaegerGRPCAuth (3.92s)
[2021-06-16T09:29:55.766Z] === RUN   TestAPMServerGRPCRequestLoggingValid
[2021-06-16T09:29:55.766Z] --- PASS: TestAPMServerGRPCRequestLoggingValid (4.86s)
[2021-06-16T09:29:55.766Z] === RUN   TestAPMServerRequestLoggingValid
[2021-06-16T09:29:55.766Z] --- PASS: TestAPMServerRequestLoggingValid (0.17s)
[2021-06-16T09:29:55.766Z] === RUN   TestApprovedMetrics
[2021-06-16T09:29:55.766Z] --- PASS: TestApprovedMetrics (4.31s)
[2021-06-16T09:29:55.766Z] === RUN   TestBreakdownMetrics
[2021-06-16T09:29:55.766Z] --- PASS: TestBreakdownMetrics (3.73s)
[2021-06-16T09:29:55.766Z] === RUN   TestApplicationMetrics
[2021-06-16T09:29:55.766Z] --- PASS: TestApplicationMetrics (3.87s)
[2021-06-16T09:29:55.766Z] === RUN   TestAPMServerMonitoring
[2021-06-16T09:29:55.766Z] --- PASS: TestAPMServerMonitoring (0.82s)
[2021-06-16T09:29:55.766Z] === RUN   TestAPMServerMonitoringBuiltinUser
[2021-06-16T09:29:55.766Z] --- PASS: TestAPMServerMonitoringBuiltinUser (2.08s)
[2021-06-16T09:29:55.766Z] === RUN   TestAPMServerOnboarding
[2021-06-16T09:29:55.766Z] --- PASS: TestAPMServerOnboarding (5.28s)
[2021-06-16T09:29:55.766Z] === RUN   TestOTLPGRPCTraces
[2021-06-16T09:29:55.766Z] --- PASS: TestOTLPGRPCTraces (3.30s)
[2021-06-16T09:29:55.766Z] === RUN   TestOTLPGRPCMetrics
[2021-06-16T09:29:55.766Z] --- PASS: TestOTLPGRPCMetrics (4.19s)
[2021-06-16T09:29:55.766Z] === RUN   TestOTLPGRPCAuth
[2021-06-16T09:29:55.766Z] --- PASS: TestOTLPGRPCAuth (4.11s)
[2021-06-16T09:29:55.766Z] === RUN   TestOTLPClientIP
[2021-06-16T09:29:55.766Z] --- PASS: TestOTLPClientIP (3.96s)
[2021-06-16T09:29:55.766Z] === RUN   TestRUMXForwardedFor
[2021-06-16T09:29:55.766Z] --- PASS: TestRUMXForwardedFor (5.12s)
[2021-06-16T09:29:55.766Z] === RUN   TestRUMErrorSourcemapping
[2021-06-16T09:29:55.766Z] --- PASS: TestRUMErrorSourcemapping (4.70s)
[2021-06-16T09:29:55.766Z] === RUN   TestRUMAuth
[2021-06-16T09:29:55.766Z] --- PASS: TestRUMAuth (0.50s)
[2021-06-16T09:29:55.766Z] === RUN   TestRUMAllowServiceNames
[2021-06-16T09:29:55.766Z] --- PASS: TestRUMAllowServiceNames (0.19s)
[2021-06-16T09:29:55.766Z] === RUN   TestRUMRateLimit
[2021-06-16T09:29:55.766Z] --- PASS: TestRUMRateLimit (1.29s)
[2021-06-16T09:29:55.766Z] === RUN   TestKeepUnsampled
[2021-06-16T09:29:55.766Z] === RUN   TestKeepUnsampled/false
[2021-06-16T09:29:55.766Z] === RUN   TestKeepUnsampled/true
[2021-06-16T09:29:55.766Z] --- PASS: TestKeepUnsampled (7.86s)
[2021-06-16T09:29:55.766Z]     --- PASS: TestKeepUnsampled/false (3.92s)
[2021-06-16T09:29:55.766Z]     --- PASS: TestKeepUnsampled/true (3.94s)
[2021-06-16T09:29:55.766Z] === RUN   TestKeepUnsampledWarning
[2021-06-16T09:29:55.766Z] --- PASS: TestKeepUnsampledWarning (5.41s)
[2021-06-16T09:29:55.766Z] === RUN   TestTailSampling
[2021-06-16T09:29:55.766Z]     sampling_test.go:135: waiting for 100 "parent" transactions
[2021-06-16T09:29:55.766Z]     sampling_test.go:135: waiting for 100 "child" transactions
[2021-06-16T09:29:55.766Z] --- PASS: TestTailSampling (4.25s)
[2021-06-16T09:29:55.766Z] === RUN   TestTailSamplingUnlicensed
[2021-06-16T09:29:55.766Z] 2021/06/16 09:29:17 Starting container id: 71fe6c4a621a image: docker.elastic.co/elasticsearch/elasticsearch:8.0.0-68ee0bbd-SNAPSHOT
[2021-06-16T09:29:55.767Z] 2021/06/16 09:29:18 Waiting for container id 71fe6c4a621a image: docker.elastic.co/elasticsearch/elasticsearch:8.0.0-68ee0bbd-SNAPSHOT
[2021-06-16T09:29:55.767Z] 2021/06/16 09:29:36 Container is ready id: 71fe6c4a621a image: docker.elastic.co/elasticsearch/elasticsearch:8.0.0-68ee0bbd-SNAPSHOT
[2021-06-16T09:29:55.767Z] --- PASS: TestTailSamplingUnlicensed (27.93s)
[2021-06-16T09:29:55.767Z] === RUN   TestIndexTemplateCoverage
[2021-06-16T09:29:55.767Z] --- PASS: TestIndexTemplateCoverage (5.37s)
[2021-06-16T09:29:55.767Z] PASS
[2021-06-16T09:29:55.767Z] ok  	github.com/elastic/apm-server/systemtest	339.163s
[2021-06-16T09:29:55.767Z] === RUN   TestAPMServer
[2021-06-16T09:29:55.767Z] 2021/06/16 09:24:10 Building apm-server...
[2021-06-16T09:29:55.767Z] 2021/06/16 09:24:12 Built /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/src/github.com/elastic/apm-server/apm-server
[2021-06-16T09:29:55.767Z] --- PASS: TestAPMServer (2.36s)
[2021-06-16T09:29:55.767Z] === RUN   TestUnstartedAPMServer
[2021-06-16T09:29:55.767Z] --- PASS: TestUnstartedAPMServer (0.00s)
[2021-06-16T09:29:55.767Z] === RUN   TestAPMServerStartTLS
[2021-06-16T09:29:55.767Z] --- PASS: TestAPMServerStartTLS (0.15s)
[2021-06-16T09:29:55.767Z] === RUN   TestExpvar
[2021-06-16T09:29:55.767Z] --- PASS: TestExpvar (0.12s)
[2021-06-16T09:29:55.767Z] PASS
[2021-06-16T09:29:55.767Z] ok  	github.com/elastic/apm-server/systemtest/apmservertest	2.660s
[2021-06-16T09:29:55.767Z] ?   	github.com/elastic/apm-server/systemtest/benchtest	[no test files]
[2021-06-16T09:29:55.767Z] ?   	github.com/elastic/apm-server/systemtest/cmd/apmbench	[no test files]
[2021-06-16T09:29:55.767Z] ?   	github.com/elastic/apm-server/systemtest/estest	[no test files]
[2021-06-16T09:29:55.767Z] ?   	github.com/elastic/apm-server/systemtest/fleettest	[no test files]
[2021-06-16T09:29:55.767Z] + cleanup
[2021-06-16T09:29:55.767Z] + rm -rf /tmp/tmp.yQpyIqNnc7
[2021-06-16T09:29:55.767Z] + .ci/scripts/docker-get-logs.sh
[2021-06-16T09:29:55.767Z] It is not possible to grab the logs of f1f199b3ac8a
[2021-06-16T09:29:57.081Z] Post stage
[2021-06-16T09:29:57.117Z] Running in /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446/src/github.com/elastic/apm-server/build
[2021-06-16T09:29:57.166Z] Archiving artifacts
[2021-06-16T09:29:57.543Z] Recording test results
[2021-06-16T09:29:58.247Z] [Checks API] No suitable checks publisher found.
[2021-06-16T09:29:58.602Z] + tar --version
[2021-06-16T09:29:58.974Z] + tar --exclude=system-tests-linux-files.tgz -czf system-tests-linux-files.tgz system-tests
[2021-06-16T09:29:59.278Z] Archiving artifacts
[2021-06-16T10:02:51.412Z] [INFO] For detailed information see: https://apm-ci.elastic.co/job/apm-integration-tests-selector-mbp/job/master/17705/display/redirect
[2021-06-16T10:02:51.831Z] Copied 17 artifacts from "APM Integration Test MBP Selector » master" build number 17705
[2021-06-16T10:02:53.118Z] Post stage
[2021-06-16T10:02:53.142Z] Recording test results
[2021-06-16T10:02:53.932Z] [Checks API] No suitable checks publisher found.
[2021-06-16T10:02:55.215Z] Running on worker-1225339 in /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5446
[2021-06-16T10:02:55.275Z] [INFO] getVaultSecret: Getting secrets
[2021-06-16T10:02:55.335Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-06-16T10:02:57.541Z] + chmod 755 generate-build-data.sh
[2021-06-16T10:02:57.541Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-server/apm-server-mbp/PR-5446/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-server/apm-server-mbp/PR-5446/runs/5 UNSTABLE 4104932
[2021-06-16T10:02:57.541Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-server/apm-server-mbp/PR-5446/runs/5/steps/?limit=10000 -o steps-info.json
[2021-06-16T10:02:58.241Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-server/apm-server-mbp/PR-5446/runs/5/tests/?status=FAILED -o tests-errors.json

simitt · 2021-06-14T10:31:11Z

/test

…compression-level

simitt · 2021-06-16T08:54:13Z

/test

Set compression level to 5 on cloud. (cherry picked from commit 1c09eed)

Set compression level to 5 on cloud. (cherry picked from commit 1c09eed) Co-authored-by: Silvia Mitter <[email protected]>

stuartnelson3 · 2021-07-09T20:17:48Z

Tested with BC2

The commands listed were both CLOUD_APM_CAPACITY=1024 ./apm-server export config, I'm assuming it was meant to be ./apm-server export config (no compression) and CLOUD_APM_CAPACITY=1024 ./apm-server export config (compression)

Set compression level to 5 on cloud. (cherry picked from commit 1c09eed) # Conflicts: # cmd/root.go # cmd/root_test.go

[cloud] default to medium compression

2720080

Set compression level to 5 on cloud.

simitt added the v7.14.0 label Jun 14, 2021

jalvz approved these changes Jun 14, 2021

View reviewed changes

Merge remote-tracking branch 'upstream/master' into cloud-set-output-…

25643b1

…compression-level

simitt merged commit 1c09eed into elastic:master Jun 16, 2021

mergify bot pushed a commit that referenced this pull request Jun 16, 2021

[cloud] default to medium compression (#5446)

1f8ed37

Set compression level to 5 on cloud. (cherry picked from commit 1c09eed)

mergify bot mentioned this pull request Jun 16, 2021

[7.x] [cloud] default to medium compression (backport #5446) #5463

Merged

simitt added a commit that referenced this pull request Jun 16, 2021

[cloud] default to medium compression (#5446) (#5463)

601440f

Set compression level to 5 on cloud. (cherry picked from commit 1c09eed) Co-authored-by: Silvia Mitter <[email protected]>

stuartnelson3 added the test-plan label Jun 29, 2021

stuartnelson3 added the test-plan-ok label Jul 9, 2021

mergify bot pushed a commit that referenced this pull request Jul 9, 2021

[cloud] default to medium compression (#5446)

e3f407d

Set compression level to 5 on cloud. (cherry picked from commit 1c09eed) # Conflicts: # cmd/root.go # cmd/root_test.go

mergify bot mentioned this pull request Jul 9, 2021

[7.14] [cloud] default to medium compression (backport #5446) #5669

Closed

simitt deleted the cloud-set-output-compression-level branch August 18, 2021 17:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[cloud] default to medium compression #5446

[cloud] default to medium compression #5446

simitt commented Jun 14, 2021

apmmachine commented Jun 14, 2021 •

edited

Loading

Build stats

Test stats 🧪

Trends 🧪

`Build and Test / Unit Test / TestSubscribeSampledTraceIDs – pubsub`

`Test Sync`

simitt commented Jun 14, 2021

simitt commented Jun 16, 2021

stuartnelson3 commented Jul 9, 2021

[cloud] default to medium compression #5446

[cloud] default to medium compression #5446

Conversation

simitt commented Jun 14, 2021

Motivation/summary

How to test these changes

apmmachine commented Jun 14, 2021 • edited Loading

💔 Tests Failed

Build stats

Test stats 🧪

Trends 🧪

Test errors

Build and Test / Unit Test / TestSubscribeSampledTraceIDs – pubsub

Steps errors

Test Sync

Log output

simitt commented Jun 14, 2021

simitt commented Jun 16, 2021

stuartnelson3 commented Jul 9, 2021

apmmachine commented Jun 14, 2021 •

edited

Loading

`Build and Test / Unit Test / TestSubscribeSampledTraceIDs – pubsub`

`Test Sync`