authorization: introduce anonymous + agent/service-specific auth #5422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a Resource type, which describes a specific resource for which authorization is being queried. This can later be used to restrict access to specific agents and services. If the supplied resource is the zero value, then the query is interpreted as checking if the requester has any access at all. If the resource is non-zero, then the query is interpreted as checking if the requester has access to that specific resource (agent/service).
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
simitt
reviewed
Jun 9, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jun 10, 2021
* beater/authorization: introduce Resource type Introduce a Resource type, which describes a specific resource for which authorization is being queried. This can later be used to restrict access to specific agents and services. If the supplied resource is the zero value, then the query is interpreted as checking if the requester has any access at all. If the resource is non-zero, then the query is interpreted as checking if the requester has access to that specific resource (agent/service). * beater/authorization: add context functions * beater/authorization: introduce AnonymousAuth * beater: check authorization for agent+service (cherry picked from commit 05cde22)
axw
added a commit
that referenced
this pull request
Jun 10, 2021
…) (#5434) * beater/authorization: introduce Resource type Introduce a Resource type, which describes a specific resource for which authorization is being queried. This can later be used to restrict access to specific agents and services. If the supplied resource is the zero value, then the query is interpreted as checking if the requester has any access at all. If the resource is non-zero, then the query is interpreted as checking if the requester has access to that specific resource (agent/service). * beater/authorization: add context functions * beater/authorization: introduce AnonymousAuth * beater: check authorization for agent+service (cherry picked from commit 05cde22) Co-authored-by: Andrew Wilkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Introduce the concept of "anonymous access", i.e. what we do for RUM today. Currently anonymous access is restricted to RUM, but we would like to extend this to the iOS agent.
In addition, we would like to be be able to restrict anonymous access to sending data for a fixed set of service names, to ensure they cannot create arbitrary data streams. To achieve this we change the
authorization.Authorizationinterface'sAuthorizedFormethod to accept a newauthorization.Resourcetype (replacing the oldelasticsearch.Resourceparam) which may contain an agent and/or service name. The authorization implementation can use these to restrict access, either through config or later for API Keys through additional_has_privilegequeries.Checklist
- [ ] Update CHANGELOG.asciidoc- [ ] Documentation has been updatedHow to test these changes
Non-functional change.
Related issues
#5347