Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make process title dynamic #5401

Merged
merged 3 commits into from
Jun 3, 2021
Merged

Conversation

jalvz
Copy link
Contributor

@jalvz jalvz commented Jun 2, 2021

This test always fails for me locally (both when running from the IDE and command line), make the conflicting field dynamic.

@apmmachine
Copy link
Contributor

apmmachine commented Jun 2, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #5401 updated

  • Start Time: 2021-06-03T13:00:19.117+0000

  • Duration: 40 min 26 sec

  • Commit: 138fd1b

Test stats 🧪

Test Results
Failed 0
Passed 6142
Skipped 120
Total 6262

Trends 🧪

Image of Build Times

Image of Tests

Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of ignoring the value in the tests, can you please update apmservertest to set a hard-coded process title?

func (defaultMetadataFilter) FilterEventMetadata(m *EventMetadata) {
m.System.Platform = "minix"
m.System.Architecture = "i386"
m.System.Container = nil
m.System.Kubernetes = nil
m.System.Hostname = "beowulf"
m.Process.Argv = nil
m.Process.Pid = 1
m.Process.Ppid = nil
m.Service.Agent.Version = "0.0.0"
m.Service.Language.Version = "2.0"
m.Service.Runtime.Version = "2.0"
m.Service.Node = nil
m.Service.Name = "systemtest"
}

That way we can continue to check that the server receives and records the value as expected.

Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jalvz jalvz merged commit 044573c into elastic:master Jun 3, 2021
@axw axw added the v7.14.0 label Jun 4, 2021
mergify bot pushed a commit that referenced this pull request Jun 4, 2021
(cherry picked from commit 044573c)
axw pushed a commit that referenced this pull request Jun 8, 2021
(cherry picked from commit 044573c)

Co-authored-by: Juan Álvarez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants