-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make process title dynamic #5401
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of ignoring the value in the tests, can you please update apmservertest to set a hard-coded process title?
apm-server/systemtest/apmservertest/filter.go
Lines 103 to 117 in 31371a1
func (defaultMetadataFilter) FilterEventMetadata(m *EventMetadata) { | |
m.System.Platform = "minix" | |
m.System.Architecture = "i386" | |
m.System.Container = nil | |
m.System.Kubernetes = nil | |
m.System.Hostname = "beowulf" | |
m.Process.Argv = nil | |
m.Process.Pid = 1 | |
m.Process.Ppid = nil | |
m.Service.Agent.Version = "0.0.0" | |
m.Service.Language.Version = "2.0" | |
m.Service.Runtime.Version = "2.0" | |
m.Service.Node = nil | |
m.Service.Name = "systemtest" | |
} |
That way we can continue to check that the server receives and records the value as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
(cherry picked from commit 044573c)
(cherry picked from commit 044573c) Co-authored-by: Juan Álvarez <[email protected]>
This test always fails for me locally (both when running from the IDE and command line), make the conflicting field dynamic.