tests/system: update metricset test #5390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
stuartnelson3
approved these changes
Jun 1, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jun 1, 2021
(cherry picked from commit 7289af3)
axw
added a commit
that referenced
this pull request
Jun 2, 2021
(cherry picked from commit 7289af3) Co-authored-by: Andrew Wilkins <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Update old Python-based system test due to the new metric added to testdata in #5360. The test is redundant with systemtest.TestApprovedMetrics, except we use the output of this one (which is a bit different) for generating user documentation. We should find another solution to that later.
How to test these changes
N/A, non-functional change.
Related issues
None.