Adding port forwarding data as this is needed to access APM server ou… #5113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tside of docker. Adding port forwarding data as this is needed to access APM server outside of docker. Without this when running on local APM server cannot be accessed with localhost:8200.
|
❌ Author of the following commits did not sign a Contributor Agreement: Please, read and sign the above mentioned agreement if you want to contribute to this project |
❕ Build Aborted
Expand to view the summary
Build stats
Trends 🧪Steps errors
Expand to view the steps failures
|
|
Thanks for the PR! I don't think we can make this change as-is, because the file you've modified is copied from beats: https://github.com/elastic/beats/blob/master/libbeat/docs/shared-docker.asciidoc @bmorelli25 any suggestions as to where/how to document this? |
|
Hello and thank you, @kartheekmannepalli! Like @axw mentioned, this update is a bit complex because the source file lives in a different repository and is copied over to the apm-server repo. Would you be willing to open this same update in that repository? Here's the file that needs to be updated: https://github.com/elastic/beats/blame/master/libbeat/docs/shared-docker.asciidoc#L246 |
|
Superseded by elastic/beats#25345. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tside of docker.
Adding port forwarding data as this is needed to access APM server outside of docker. Without this when running on local APM server cannot be accessed with localhost:8200.
Motivation/summary
Checklist
For functional changes, consider:
How to test these changes
Related issues