-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metadata to API Keys created by server #5090
Conversation
Add `application: "apm"` in the metadata of API Keys created by APM Server, so they can later be identified as having been created by/for APM. The metadata must not be used for auth; it is purely for informational purposes.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
@sqren tagged you for review just to check that the metadata I've proposed here is OK. |
Add `application: "apm"` in the metadata of API Keys created by APM Server, so they can later be identified as having been created by/for APM. The metadata must not be used for auth; it is purely for informational purposes. (cherry picked from commit 90d05c3) # Conflicts: # changelogs/head.asciidoc
* Add metadata to API Keys created by server (#5090) Add `application: "apm"` in the metadata of API Keys created by APM Server, so they can later be identified as having been created by/for APM. The metadata must not be used for auth; it is purely for informational purposes. (cherry picked from commit 90d05c3) # Conflicts: # changelogs/head.asciidoc * Delete head.asciidoc Co-authored-by: Andrew Wilkins <[email protected]>
Add `application: "apm"` in the metadata of API Keys created by APM Server, so they can later be identified as having been created by/for APM. The metadata must not be used for auth; it is purely for informational purposes. (cherry picked from commit 90d05c3) # Conflicts: # changelogs/7.13.asciidoc
Tested against commit https://github.com/elastic/apm-server/commits/0aa1b50a5b680be19556d53f870fa9723bdc9a03,
|
Motivation/summary
Add
application: "apm"
in the metadata of API Keys created by APM Server, so they can later be identified as having been created by/for APM. The metadata must not be used for auth; it is purely for informational purposes.Metadata will be shown when running
apm-server apikey info
with the--json
flag, but not in the default text format.Checklist
How to test these changes
apm-server apikey create
apm-server apikey info --json --id <id-from-step-1>
, check the metadata shows{"application": "apm"}
Related issues
#3461
elastic/kibana#77966