Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intake: add cloud.service.name to metadata #4626

Merged
merged 6 commits into from
Jan 25, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,9 @@ and merged with "Create a merge commit".
Straightforward backports may be merged without review.

[Backport](https://github.com/sqren/backport) is recommended for automating the backport process.

### Examples

This is a collection of example PRs for additions occuring somewhat frequently.

* [Adding a new field to the Intake API and index it in Elasticsearch](https://github.com/elastic/apm-server/pull/4626#issue-555484976)
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
- name: cloud.service.name
level: extended
type: keyword
description: |
Cloud service name, intended to distinguish services running on different platforms within a provider.
ignore_above: 1024
- name: experimental
type: object
description: Additional experimental data sent by the agents.
Expand Down
6 changes: 6 additions & 0 deletions apmpackage/apm/0.1.0/data_stream/error_logs/fields/fields.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
- name: cloud.service.name
level: extended
type: keyword
description: |
Cloud service name, intended to distinguish services running on different platforms within a provider.
ignore_above: 1024
- name: error.culprit
type: keyword
description: Function call which was the primary perpetrator of this event.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
- name: cloud.service.name
level: extended
type: keyword
description: |
Cloud service name, intended to distinguish services running on different platforms within a provider.
ignore_above: 1024
- name: experimental
type: object
description: Additional experimental data sent by the agents.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
- name: cloud.service.name
level: extended
type: keyword
description: |
Cloud service name, intended to distinguish services running on different platforms within a provider.
ignore_above: 1024
- name: experimental
type: object
description: Additional experimental data sent by the agents.
Expand Down
6 changes: 6 additions & 0 deletions apmpackage/apm/0.1.0/data_stream/traces/fields/fields.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@
type: keyword
description: |
The ID(s)s of the child event(s).
- name: cloud.service.name
level: extended
type: keyword
description: |
Cloud service name, intended to distinguish services running on different platforms within a provider.
ignore_above: 1024
- name: experimental
type: object
description: Additional experimental data sent by the agents.
Expand Down
3 changes: 3 additions & 0 deletions apmpackage/apm/0.1.0/docs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ Traces are written to `traces-apm.*` indices.
|cloud.project.name|Cloud project name|keyword| ![](https://doc-icons.s3.us-east-2.amazonaws.com/icon-yes.png) |
|cloud.provider|Cloud provider name|keyword| ![](https://doc-icons.s3.us-east-2.amazonaws.com/icon-yes.png) |
|cloud.region|Cloud region name|keyword| ![](https://doc-icons.s3.us-east-2.amazonaws.com/icon-yes.png) |
|cloud.service.name|Cloud service name, intended to distinguish services running on different platforms within a provider.|keyword| ![](https://doc-icons.s3.us-east-2.amazonaws.com/icon-no.png) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wrong, isn't it? I think we need to update the ECS version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It hasn't been released, so for now this is true.

|container.id|Unique container id.|keyword| ![](https://doc-icons.s3.us-east-2.amazonaws.com/icon-yes.png) |
|destination.address|Some event destination addresses are defined ambiguously. The event will sometimes list an IP, a domain or a unix socket. You should always store the raw address in the `.address` field. Then it should be duplicated to `.ip` or `.domain`, depending on which one it is.|keyword| ![](https://doc-icons.s3.us-east-2.amazonaws.com/icon-yes.png) |
|destination.ip|IP addess of the destination. Can be one of multiple IPv4 or IPv6 addresses.|ip| ![](https://doc-icons.s3.us-east-2.amazonaws.com/icon-yes.png) |
Expand Down Expand Up @@ -449,6 +450,7 @@ Metrics are written to `metrics-apm.*`, `metrics-apm.internal.*` and `metrics-ap
|cloud.project.name|Cloud project name|keyword| ![](https://doc-icons.s3.us-east-2.amazonaws.com/icon-yes.png) |
|cloud.provider|Cloud provider name|keyword| ![](https://doc-icons.s3.us-east-2.amazonaws.com/icon-yes.png) |
|cloud.region|Cloud region name|keyword| ![](https://doc-icons.s3.us-east-2.amazonaws.com/icon-yes.png) |
|cloud.service.name|Cloud service name, intended to distinguish services running on different platforms within a provider.|keyword| ![](https://doc-icons.s3.us-east-2.amazonaws.com/icon-no.png) |
|container.id|Unique container id.|keyword| ![](https://doc-icons.s3.us-east-2.amazonaws.com/icon-yes.png) |
|destination.address|Some event destination addresses are defined ambiguously. The event will sometimes list an IP, a domain or a unix socket. You should always store the raw address in the `.address` field. Then it should be duplicated to `.ip` or `.domain`, depending on which one it is.|keyword| ![](https://doc-icons.s3.us-east-2.amazonaws.com/icon-yes.png) |
|destination.ip|IP addess of the destination. Can be one of multiple IPv4 or IPv6 addresses.|ip| ![](https://doc-icons.s3.us-east-2.amazonaws.com/icon-yes.png) |
Expand Down Expand Up @@ -601,6 +603,7 @@ Logs are written to `logs-apm.error.*` indices.
|cloud.project.name|Cloud project name|keyword| ![](https://doc-icons.s3.us-east-2.amazonaws.com/icon-yes.png) |
|cloud.provider|Cloud provider name|keyword| ![](https://doc-icons.s3.us-east-2.amazonaws.com/icon-yes.png) |
|cloud.region|Cloud region name|keyword| ![](https://doc-icons.s3.us-east-2.amazonaws.com/icon-yes.png) |
|cloud.service.name|Cloud service name, intended to distinguish services running on different platforms within a provider.|keyword| ![](https://doc-icons.s3.us-east-2.amazonaws.com/icon-no.png) |
|container.id|Unique container id.|keyword| ![](https://doc-icons.s3.us-east-2.amazonaws.com/icon-yes.png) |
|destination.address|Some event destination addresses are defined ambiguously. The event will sometimes list an IP, a domain or a unix socket. You should always store the raw address in the `.address` field. Then it should be duplicated to `.ip` or `.domain`, depending on which one it is.|keyword| ![](https://doc-icons.s3.us-east-2.amazonaws.com/icon-yes.png) |
|destination.ip|IP addess of the destination. Can be one of multiple IPv4 or IPv6 addresses.|ip| ![](https://doc-icons.s3.us-east-2.amazonaws.com/icon-yes.png) |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,10 @@
"name": "project_name"
},
"provider": "cloud_provider",
"region": "cloud_region"
"region": "cloud_region",
"service": {
"name": "lambda"
}
},
"container": {
"id": "container-id"
Expand Down Expand Up @@ -381,7 +384,10 @@
"name": "project_name"
},
"provider": "cloud_provider",
"region": "cloud_region"
"region": "cloud_region",
"service": {
"name": "lambda"
}
},
"container": {
"id": "container-id"
Expand Down Expand Up @@ -496,7 +502,10 @@
"name": "project_name"
},
"provider": "cloud_provider",
"region": "cloud_region"
"region": "cloud_region",
"service": {
"name": "lambda"
}
},
"container": {
"id": "container-id"
Expand Down Expand Up @@ -607,7 +616,10 @@
"name": "project_name"
},
"provider": "cloud_provider",
"region": "cloud_region"
"region": "cloud_region",
"service": {
"name": "lambda"
}
},
"container": {
"id": "container-id"
Expand Down Expand Up @@ -724,7 +736,10 @@
"name": "project_name"
},
"provider": "cloud_provider",
"region": "cloud_region"
"region": "cloud_region",
"service": {
"name": "lambda"
}
},
"container": {
"id": "container-id"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,10 @@
"name": "project_name"
},
"provider": "cloud_provider",
"region": "cloud_region"
"region": "cloud_region",
"service": {
"name": "lambda"
}
},
"container": {
"id": "container-id"
Expand Down Expand Up @@ -155,7 +158,10 @@
"name": "project_name"
},
"provider": "cloud_provider",
"region": "cloud_region"
"region": "cloud_region",
"service": {
"name": "lambda"
}
},
"container": {
"id": "container-id"
Expand Down Expand Up @@ -282,7 +288,10 @@
"name": "project_name"
},
"provider": "cloud_provider",
"region": "cloud_region"
"region": "cloud_region",
"service": {
"name": "lambda"
}
},
"container": {
"id": "container-id"
Expand Down Expand Up @@ -413,7 +422,10 @@
"name": "project_name"
},
"provider": "cloud_provider",
"region": "cloud_region"
"region": "cloud_region",
"service": {
"name": "lambda"
}
},
"container": {
"id": "container-id"
Expand Down Expand Up @@ -541,7 +553,10 @@
"name": "project_name"
},
"provider": "cloud_provider",
"region": "cloud_region"
"region": "cloud_region",
"service": {
"name": "lambda"
}
},
"container": {
"id": "container-id"
Expand Down Expand Up @@ -751,7 +766,10 @@
"name": "project_name"
},
"provider": "cloud_provider",
"region": "cloud_region"
"region": "cloud_region",
"service": {
"name": "lambda"
}
},
"container": {
"id": "container-id"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,10 @@
"name": "project_name"
},
"provider": "cloud_provider",
"region": "cloud_region"
"region": "cloud_region",
"service": {
"name": "lambda"
}
},
"container": {
"id": "container-id"
Expand Down Expand Up @@ -153,7 +156,10 @@
"name": "project_name"
},
"provider": "cloud_provider",
"region": "cloud_region"
"region": "cloud_region",
"service": {
"name": "lambda"
}
},
"container": {
"id": "container-id"
Expand Down Expand Up @@ -373,7 +379,10 @@
"name": "project_name"
},
"provider": "cloud_provider",
"region": "cloud_region"
"region": "cloud_region",
"service": {
"name": "lambda"
}
},
"container": {
"id": "container-id"
Expand Down Expand Up @@ -525,7 +534,10 @@
"name": "project_name"
},
"provider": "cloud_provider",
"region": "cloud_region"
"region": "cloud_region",
"service": {
"name": "lambda"
}
},
"container": {
"id": "container-id"
Expand Down
1 change: 1 addition & 0 deletions changelogs/head.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ https://github.com/elastic/apm-server/compare/7.11\...master[View commits]

[float]
==== Intake API Changes
* Add `cloud.service.name` support for metadata {pull}4626[4626]

[float]
==== Added
Expand Down
65 changes: 65 additions & 0 deletions docs/fields.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -1250,6 +1250,19 @@ example: us-east1

--


*`cloud.service.name`*::
+
--
Cloud service name, intended to distinguish services running on different platforms within a provider.


type: keyword

{yes-icon} {ecs-ref}[ECS] field.

--

[float]
=== error

Expand Down Expand Up @@ -2280,6 +2293,19 @@ example: us-east1
--


*`cloud.service.name`*::
+
--
Cloud service name, intended to distinguish services running on different platforms within a provider.


type: keyword

{yes-icon} {ecs-ref}[ECS] field.

--


*`profile.id`*::
+
--
Expand Down Expand Up @@ -3534,6 +3560,19 @@ example: us-east1
--


*`cloud.service.name`*::
+
--
Cloud service name, intended to distinguish services running on different platforms within a provider.


type: keyword

{yes-icon} {ecs-ref}[ECS] field.

--


*`event.outcome`*::
+
--
Expand Down Expand Up @@ -5081,6 +5120,19 @@ example: us-east1
--


*`cloud.service.name`*::
+
--
Cloud service name, intended to distinguish services running on different platforms within a provider.


type: keyword

{yes-icon} {ecs-ref}[ECS] field.

--


*`event.outcome`*::
+
--
Expand Down Expand Up @@ -6173,6 +6225,19 @@ example: us-east1
--


*`cloud.service.name`*::
+
--
Cloud service name, intended to distinguish services running on different platforms within a provider.


type: keyword

{yes-icon} {ecs-ref}[ECS] field.

--


*`event.outcome`*::
+
--
Expand Down
17 changes: 17 additions & 0 deletions docs/spec/v2/metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,23 @@
"string"
],
"maxLength": 1024
},
"service": {
"description": "Service that is monitored on cloud",
"type": [
"null",
"object"
],
"properties": {
"name": {
"description": "Name of the cloud service, intended to distinguish services running on different platforms within a provider, eg AWS EC2 vs Lambda, GCP GCE vs App Engine, Azure VM vs App Server.",
"type": [
"null",
"string"
],
"maxLength": 1024
}
}
}
},
"required": [
Expand Down
Loading