[7.x] Move APM-specific template defaults to idxmgmt (#4458) #4526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move APM-specific template defaults to idxmgmt Move APM-specific `setup.template.settings` defaults away from using config overrides, and add the logic to the idxmgmt package. Similarly drop `logging.files.rotateeverbytes`, as we were setting what is already the default defined by libbeat. Now when you run `apm-server export config`, these defaults do not show up at all. The relevant system tests have been migrated to Go, and the expectations updated to match the change in behaviour. We customise `logging.metrics.enabled`, and there is no other way to change the default before it is interpreted by libbeat, so it remains in config overrides for now.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errors
Expand to view the steps failures
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: