Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package_tests: remove validation tests #4467

Merged
merged 1 commit into from
Nov 30, 2020

Conversation

axw
Copy link
Member

@axw axw commented Nov 30, 2020

Motivation/summary

These tests are redundant with the new modeldecoder code, where we test the generated validation logic directly.

Checklist

I have considered changes for:
- [ ] documentation
- [ ] logging (add log lines, choose appropriate log selector, etc.)
- [ ] metrics and monitoring (create issue for Kibana team to add metrics to visualizations, e.g. Kibana#44001)

How to test these changes

make test

Related issues

#4465

These tests are redundant with the new modeldecoder code,
where we test the generated validation logic directly.
@axw axw requested a review from a team November 30, 2020 14:04
@apmmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #4467 opened

  • Start Time: 2020-11-30T14:04:18.344+0000

  • Duration: 41 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 4739
Skipped 143
Total 4882

Steps errors 3

Expand to view the steps failures

Compress

  • Took 0 min 0 sec . View more details on here
  • Description: tar --exclude=coverage-files.tgz -czf coverage-files.tgz coverage

Compress

  • Took 0 min 0 sec . View more details on here
  • Description: tar --exclude=system-tests-linux-files.tgz -czf system-tests-linux-files.tgz system-tests

Test Sync

  • Took 3 min 10 sec . View more details on here
  • Description: ./.ci/scripts/sync.sh

@axw axw merged commit 6239ef4 into elastic:master Nov 30, 2020
@axw axw deleted the package-tests-validation branch November 30, 2020 15:28
axw added a commit to axw/apm-server that referenced this pull request Dec 14, 2020
These tests are redundant with the new modeldecoder code,
where we test the generated validation logic directly.
axw added a commit that referenced this pull request Dec 14, 2020
These tests are redundant with the new modeldecoder code,
where we test the generated validation logic directly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants