fix: ensure ES index names are lowercase #4295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure customized index names are always lowercase, fixing regression introduced with https://github.com/elastic/beats/pull/18854/files fixes elastic#4294
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errors
Expand to view the tests failures
Steps errors
Expand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
axw
approved these changes
Oct 12, 2020
Codecov Report
@@ Coverage Diff @@
## master #4295 +/- ##
=======================================
Coverage 79.73% 79.73%
=======================================
Files 161 161
Lines 8984 8984
=======================================
Hits 7163 7163
Misses 1821 1821 |
simitt
added a commit
to simitt/apm-server
that referenced
this pull request
Oct 12, 2020
Ensure customized index names are always lowercase, fixing regression introduced with https://github.com/elastic/beats/pull/18854/files fixes elastic#4294
simitt
added a commit
to simitt/apm-server
that referenced
this pull request
Oct 12, 2020
Ensure customized index names are always lowercase, fixing regression introduced with https://github.com/elastic/beats/pull/18854/files fixes elastic#4294
simitt
added a commit
to simitt/apm-server
that referenced
this pull request
Oct 12, 2020
Ensure customized index names are always lowercase, fixing regression introduced with https://github.com/elastic/beats/pull/18854/files fixes elastic#4294
simitt
added a commit
that referenced
this pull request
Oct 12, 2020
Ensure customized index names are always lowercase, fixing regression introduced with https://github.com/elastic/beats/pull/18854/files fixes #4294
simitt
added a commit
that referenced
this pull request
Oct 12, 2020
Ensure customized index names are always lowercase, fixing regression introduced with https://github.com/elastic/beats/pull/18854/files fixes #4294
simitt
added a commit
that referenced
this pull request
Oct 12, 2020
Ensure customized index names are always lowercase, fixing regression introduced with https://github.com/elastic/beats/pull/18854/files fixes #4294
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
A regression was introduced when pulling in libbeat changes from elastic/beats#18854. Libbeat no longer guarantees lower case index names for all outputs, but rather moved the implementation to the standard index manager. APM Server implements its own index manager but did not apply changes when upgrading to libbeat changes.
This PR fixes the regression by ensuring index names are lowercased when derived from the
event, and from themetaaliasorindexinformation.Checklist
- [ ] I have signed the Contributor License Agreement.I have considered changes for:
- [ ] documentation- [ ] logging (add log lines, choose appropriate log selector, etc.)- [ ] metrics and monitoring (create issue for Kibana team to add metrics to visualizations, e.g. Kibana#44001)- [ ] telemetry- [ ] Elasticsearch Service (https://cloud.elastic.co)- [ ] Elastic Cloud Enterprise (https://www.elastic.co/products/ece)- [ ] Elastic Cloud on Kubernetes (https://www.elastic.co/elastic-cloud-kubernetes)How to test these changes
apm-server.ymlcontaining upper casesRelated issues
fixes #4294