Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: APM Server documentation updates #4126

Merged
merged 16 commits into from
Sep 9, 2020

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Sep 1, 2020

Summary

This PR...

Syncs APM Server documentation with recent Beats changes

Adds APM only updates

Other required changes

Related issues

Closes #4002.
Closes #3705.

@apmmachine
Copy link
Contributor

apmmachine commented Sep 1, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #4126 updated]

  • Start Time: 2020-09-09T02:30:48.011+0000

  • Duration: 3 min 15 sec

@bmorelli25 bmorelli25 requested a review from a team September 1, 2020 19:35
@bmorelli25 bmorelli25 marked this pull request as ready for review September 1, 2020 19:35
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good, but there seems to be an issue with the navigation structure:

https://apm-server_4126.docs-preview.app.elstc.co/guide/en/apm/server/master/apm-server-template.html

Shows up as a sibling to "Elasticsearch index template", which still has a "Manually loading template configuration" child page - but that is empty. I think that one should have been replaced?

@bmorelli25
Copy link
Member Author

@elasticmachine, run elasticsearch-ci/docs

@bmorelli25 bmorelli25 merged commit ce44169 into elastic:master Sep 9, 2020
bmorelli25 added a commit to bmorelli25/apm-server that referenced this pull request Sep 9, 2020
bmorelli25 added a commit to bmorelli25/apm-server that referenced this pull request Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cipher suites table to APM server SSL input settings docs: clarify output documentation
3 participants