Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Support custom response headers for RUM endpoints (#3820) #3825

Merged
merged 1 commit into from
May 28, 2020

Conversation

jalvz
Copy link
Contributor

@jalvz jalvz commented May 27, 2020

Backports the following commits to 7.x:

@jalvz jalvz added the backport label May 27, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #3825 into 7.x will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              7.x    #3825      +/-   ##
==========================================
- Coverage   79.91%   79.90%   -0.01%     
==========================================
  Files         136      137       +1     
  Lines        6158     6166       +8     
==========================================
+ Hits         4921     4927       +6     
- Misses       1237     1239       +2     
Impacted Files Coverage Δ
beater/config/rum.go 79.41% <ø> (ø)
beater/api/mux.go 80.32% <100.00%> (+0.16%) ⬆️
beater/middleware/response_headers_middleware.go 100.00% <100.00%> (ø)
beater/jaeger/common.go 78.78% <0.00%> (-6.07%) ⬇️

@jalvz jalvz merged commit bd456fe into elastic:7.x May 28, 2020
@axw
Copy link
Member

axw commented Jul 21, 2020

Verified with BC2.

Configured apm-server with -E apm-server.rum.response_headers={key: 'value'}, and confirmed that each of the RUM endpoints responded with an additional header, "Key: value":

  • /config/v1/rum/agents
  • /intake/v2/rum/events
  • /intake/v3/rum/events

Also confirmed that non-RUM endpoints do not respond with the header. This includes the root endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants