[7.x] beater: CreatorParams.RunServer -> WrapRunServer (#3803) #3805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* beater: CreatorParams.RunServer -> WrapRunServer Rather than passing in a RunServerFunc to CreatorParams, pass in a function that can wrap a RunServerFunc, like middleware. This enables us to run the tracer server with an overridden reporter, such as the one provided by the transaction histogram aggregator. Unexport beater.RunServer to ensure wrappers do not mistakenly call it directly, rather than going through the RunServerFunc provided to them. * beater: extract runServerWithTracerServer
Codecov Report
@@ Coverage Diff @@
## 7.x #3805 +/- ##
==========================================
- Coverage 79.83% 79.79% -0.04%
==========================================
Files 136 136
Lines 6158 6158
==========================================
- Hits 4916 4914 -2
- Misses 1242 1244 +2
|
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: