-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update beats framework to 990a5f7 #3289
Conversation
@elastic/apm-server Anyone know what's going on with the vendored |
@graphaelli I think we need the newer version for Jaeger support. IIRC, nothing in libbeat depends on it, so it should be safe. @simitt does that sound right to you? |
Agree with what @axw said, I needed to update the library when adding Jaeger support. |
b770a60
to
fafc530
Compare
Good point @simitt, I wasn't thinking that origin was related. github.com/gogo/protobuf has been updated in beats and is reflected here now. Sorry about the force push, was the most straightforward way to update this. |
looking into this issue
|
* added origins to vendor/vendor.json for 2 deps where missing * script/update_govendor_deps.py 990a5f76a3dc435bf783c1f44d9363abac211a0e
Codecov Report
@@ Coverage Diff @@
## master #3289 +/- ##
=======================================
Coverage 79.82% 79.82%
=======================================
Files 107 107
Lines 5625 5625
=======================================
Hits 4490 4490
Misses 1135 1135 |
Two more origins were missing, added them manually and updated them with govendor. |
Mostly for #3277