beater/middleware: add trace/log correlation #3136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
force-pushed
the
log-trace-correlation
branch
from
bc4ddea to
f078975
Compare
axw
added a commit
to axw/apm-server
that referenced
this pull request
Jan 13, 2020
axw
added a commit
that referenced
this pull request
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the logging middleware, add
trace.idandtransaction.idfields if the request is being traced. If traced, reuse the transaction ID for the existingrequest_idfield, rather than generating another UUID.I have manually tested this with apm-integration-testing (using
--with-filebeat), checking that a user can jump between the APM and Logs app in both directions.Closes #3075