Fix numeric user id decoding #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
already allowed by intake spec
graphaelli
commented
Apr 24, 2019
| user.Id = &id | ||
| } else if t, ok := tmp.(string); ok && t != "" { | ||
| user.Id = &t | ||
| } |
There was a problem hiding this comment.
@elastic/apm-server I've only backported what is on master for the moment but believe this should add a decoding error if Id is not a json.Number or string, even if that isn't possible via intake.
simitt
approved these changes
Apr 25, 2019
changelogs/6.7.asciidoc
Outdated
| @@ -3,9 +3,22 @@ | |||
|
|
|||
| https://github.com/elastic/apm-server/compare/6.6\...6.7[View commits] | |||
|
|
|||
| //* <<release-notes-6.721>> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
already allowed by intake spec
backports part of #1783
closes #2127