-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate default docker image to ubi-micro #14786
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove the tini & docker-entrypoint files?
Done! 😄 |
Out of curiosity, I've seen apm-server/packaging/ironbank/hardening_manifest.yaml Lines 42 to 46 in 767abab
|
tini is not needed in recent docker versions because it's included in docker (kubernetes is in a similar position) so we just need to ensure we're running the binary directly without wrapping it in a shell script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @kruskall!
Motivation/summary
In line with other products and with the direction in #13872 we want to drop ubuntu and use ubi base images for the default image.
Similar to what we did with the chainguard image, the image is pinned to a digest for security/reproducibility and tini is dropped since it's not needed in modern docker versions.
Checklist
For functional changes, consider:
How to test these changes
docker build . -f packaging/docker/Dockerfile -t ubi-micro-apm-server --build-arg GOLANG_VERSION=1.23
docker run ubi-micro-apm-server
(note if you don't pass an elasticsearch url it will useelasticsearch
by default).Related issues