Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildkite(dra): retry if package failed #14783

Merged
merged 2 commits into from
Dec 3, 2024
Merged

buildkite(dra): retry if package failed #14783

merged 2 commits into from
Dec 3, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented Dec 2, 2024 •
edited
Loading

This should help when flakiness when fetching dependencies. Althought, might add a bit of time to report a genuine failure.

https://buildkite.com/docs/pipelines/configure/step-types/command-step#retry-attributes explains how to use it

Motivation/summary

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

@v1v
buildkite(dra): retry if package failed
60a6e2d 
This should help when flakiness when fetching dependencies

Will help with retrying autoamtically

might add a bit of time to report a genuine failure
@v1v v1v self-assigned this Dec 2, 2024
@v1v v1v requested a review from a team as a code owner December 2, 2024 17:35
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 2, 2024

This pull request does not have a backport label. Could you fix it @v1v? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 2, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Dec 2, 2024
@v1v v1v added backport-7.17 Automated backport with mergify to the 7.17 branch backport-8.17 Automated backport with mergify backport-8.16 Automated backport with mergify labels Dec 2, 2024
@v1v v1v requested a review from a team December 2, 2024 17:37
@v1v v1v enabled auto-merge (squash) December 3, 2024 08:36
@v1v v1v merged commit 767abab into main Dec 3, 2024
12 checks passed
@v1v v1v deleted the feature/retry-rebuild-if-something-goes-wrong branch December 3, 2024 08:45
mergify bot pushed a commit that referenced this pull request Dec 3, 2024
@v1v @mergify
buildkite(dra): retry if package failed (#14783)
301b035 
(cherry picked from commit 767abab)
@mergify mergify bot mentioned this pull request Dec 3, 2024
Merged
2 tasks
mergify bot pushed a commit that referenced this pull request Dec 3, 2024
@v1v @mergify
buildkite(dra): retry if package failed (#14783)
9138692 
(cherry picked from commit 767abab)
@mergify mergify bot mentioned this pull request Dec 3, 2024
Merged
2 tasks
mergify bot pushed a commit that referenced this pull request Dec 3, 2024
@v1v @mergify
buildkite(dra): retry if package failed (#14783)
fef1c63 
(cherry picked from commit 767abab)
@mergify mergify bot mentioned this pull request Dec 3, 2024
Merged
2 tasks
mergify bot added a commit that referenced this pull request Dec 3, 2024
@mergify @v1v
buildkite(dra): retry if package failed (#14783) (#14788)
4e767a4 
(cherry picked from commit 767abab)

Co-authored-by: Victor Martinez <[email protected]>
mergify bot added a commit that referenced this pull request Dec 3, 2024
@mergify @v1v
buildkite(dra): retry if package failed (#14783) (#14789)
feb46c7 
(cherry picked from commit 767abab)

Co-authored-by: Victor Martinez <[email protected]>
mergify bot added a commit that referenced this pull request Dec 3, 2024
@mergify @v1v
buildkite(dra): retry if package failed (#14783) (#14787)
bc43375 
(cherry picked from commit 767abab)

Co-authored-by: Victor Martinez <[email protected]>
@carsonip
Copy link
Member

carsonip commented Dec 3, 2024

@mergify backport 8.17

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 3, 2024 •
edited
Loading

backport 8.17

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 3, 2024
@v1v @mergify
buildkite(dra): retry if package failed (#14783)
08647ce 
(cherry picked from commit 767abab)
@mergify mergify bot mentioned this pull request Dec 3, 2024
Merged
2 tasks
mergify bot added a commit that referenced this pull request Dec 3, 2024
@mergify @v1v
buildkite(dra): retry if package failed (#14783) (#14809)
4df8aa3 
(cherry picked from commit 767abab)

Co-authored-by: Victor Martinez <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1pkg 1pkg 1pkg approved these changes

@reakaleek reakaleek reakaleek approved these changes

Assignees

@v1v v1v

Labels
backport-7.17 Automated backport with mergify to the 7.17 branch backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v1v @carsonip @reakaleek @1pkg