fix: move beats cfgfile.HandleFlags call after the flags are parsed #14512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
1pkg
force-pushed
the
fix_cfgfile_handle_flag_parse_entrypoint
branch
from
652b284 to
f1dc8a4
Compare
leehinman
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
LGTM
did a quick test on my end. tested with and without apm-server.yml in the directory and everything worked fine.
Tested with -E management.enabled=true and apm server correctly waited for it's config on stdin.
Tested with ./apm-server -E management.enabled=false -E logging.leve=debug --E logging.to_stderr=true --memprofile -1s -c ./apm-server.yml.bk and it found correct config file, wrote the memprofile to the file called "-1s", and correct debug level to stderr.
marclop
approved these changes
Nov 4, 2024
kruskall
approved these changes
Nov 4, 2024
Merged
2 tasks
mergify bot
added a commit
that referenced
this pull request
Nov 4, 2024
…14512) (#14537) * fix: move beats cfgfile.HandleFlags call after the flags are parsed * fix: beats call to ConvertFlagsForBackwardsCompatibility on init * fix: beatcmd add remaining flag into backward compatibble flags list (cherry picked from commit e2c0fb5) Co-authored-by: Kostiantyn Masliuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
This PR fixes the issue with flags parsing in APM Server beats cmd. By moving
cfgfile.HandleFlagsto after the point when the flags are parsed by the cobra cli.Checklist
For functional changes, consider:
How to test these changes
Build a snapshot EA image for ESS and run it.
Related issues
elastic/elastic-agent#589