Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PGO: optimize collected profile file size #14256

Merged
merged 3 commits into from
Oct 4, 2024
Merged

PGO: optimize collected profile file size #14256

merged 3 commits into from
Oct 4, 2024

Conversation

1pkg
Copy link
Member

@1pkg 1pkg commented Oct 3, 2024

Motivation/summary

This PR addresses the issue #14255, by applying some quick optimization to how CPU profiles are collected for PGO. It reduces total collection time to 5% and strips unnecessary data such as tags and profile memory addresses that don't affect PGO.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

#14255
#13884

@1pkg 1pkg self-assigned this Oct 3, 2024
@1pkg 1pkg requested a review from a team as a code owner October 3, 2024 23:02
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 3, 2024

This pull request does not have a backport label. Could you fix it @1pkg? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 3, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 3, 2024
@1pkg 1pkg removed the backport-8.x Automated backport to the 8.x branch with mergify label Oct 3, 2024
@1pkg 1pkg mentioned this pull request Oct 3, 2024
Closed
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 3, 2024

This pull request does not have a backport label. Could you fix it @1pkg? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 3, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 3, 2024
@1pkg 1pkg removed the backport-8.x Automated backport to the 8.x branch with mergify label Oct 3, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 3, 2024

This pull request does not have a backport label. Could you fix it @1pkg? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 3, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 3, 2024
axw
axw previously approved these changes Oct 4, 2024
View reviewed changes
@1pkg
Copy link
Member Author

1pkg commented Oct 4, 2024

The result #14260

@1pkg 1pkg added backport-skip Skip notification from the automated backport with mergify and removed backport-8.x Automated backport to the 8.x branch with mergify labels Oct 4, 2024
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Oct 4, 2024
@1pkg 1pkg enabled auto-merge (squash) October 4, 2024 16:50
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 4, 2024

This pull request does not have a backport label. Could you fix it @1pkg? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 4, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 4, 2024
@1pkg 1pkg merged commit 3833927 into main Oct 4, 2024
11 checks passed
@1pkg 1pkg deleted the pgo_optimize_profile_size branch October 4, 2024 16:57
mergify bot pushed a commit that referenced this pull request Oct 4, 2024
@1pkg @mergify
PGO: optimize collected profile file size (#14256)
93a36c9 
(cherry picked from commit 3833927)

# Conflicts:
#	.github/workflows/benchmarks.yml
#	systemtest/benchtest/profiles.go
#	testing/benchmark/Makefile
@mergify mergify bot mentioned this pull request Oct 4, 2024
Merged
2 tasks
mergify bot added a commit that referenced this pull request Oct 11, 2024
@mergify @1pkg
PGO: optimize collected profile file size (#14256) (#14267)
7097284 
(cherry picked from commit 3833927)

# Conflicts:
#	.github/workflows/benchmarks.yml
#	systemtest/benchtest/profiles.go
#	testing/benchmark/Makefile

Co-authored-by: Kostiantyn Masliuk <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marclop marclop marclop approved these changes

@axw axw axw left review comments

Assignees

@1pkg 1pkg

Labels
backport-8.x Automated backport to the 8.x branch with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@1pkg @axw @marclop