smoke tests: Ignore version 9.0.0 #14176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omits running the smoke tests against 9.0.0-SNAPSHOT, since the it's still in its infancy and other components aren't working properly at the moment. Given how far out the release is and that it breaks the smoke tests, it skips testing that version. Signed-off-by: Marc Lopez Rubio <[email protected]>
Signed-off-by: Marc Lopez Rubio <[email protected]>
Signed-off-by: Marc Lopez Rubio <[email protected]>
Signed-off-by: Marc Lopez Rubio <[email protected]>
Signed-off-by: Marc Lopez Rubio <[email protected]>
|
This pull request does not have a backport label. Could you fix it @marclop? 🙏
|
|
|
mergify
bot
added
the
backport-8.x
kruskall
reviewed
Sep 25, 2024
| VERSION=${1} | ||
| if [[ -z ${VERSION} ]] || [[ "${VERSION}" == "latest" ]]; then | ||
| VERSION=$(curl -s "https://artifacts-api.elastic.co/v1/versions" | jq -r '.versions[-1]') | ||
| VERSION=$(curl -s "https://artifacts-api.elastic.co/v1/versions" | jq -r --arg IGNORE_VERSION "$IGNORE_VERSION" '.versions | map(select(. != $IGNORE_VERSION))[-1]') |
There was a problem hiding this comment.
question: would this work with 9.0.1 ? WDYT about checking that the version string starts with 8. (similar to what you did below) ?
I'm wondering this since this also needs to be backported to 8.x so we should try to be as compatible as possible
Signed-off-by: Marc Lopez Rubio <[email protected]>
kruskall
approved these changes
Sep 25, 2024
1pkg
approved these changes
Sep 25, 2024
mergify bot
pushed a commit
that referenced
this pull request
Sep 26, 2024
Omits running the smoke tests against 9.0.0-SNAPSHOT, since the it's still in its infancy and other components aren't working properly at the moment. Given how far out the release is and that it breaks the smoke tests, it skips testing that version. --------- Signed-off-by: Marc Lopez Rubio <[email protected]> (cherry picked from commit f37135a)
mergify bot
added a commit
that referenced
this pull request
Sep 26, 2024
Omits running the smoke tests against 9.0.0-SNAPSHOT, since the it's still in its infancy and other components aren't working properly at the moment. Given how far out the release is and that it breaks the smoke tests, it skips testing that version. --------- Signed-off-by: Marc Lopez Rubio <[email protected]> (cherry picked from commit f37135a) Co-authored-by: Marc Lopez Rubio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Ignore version 9.0.0 since it's quite far away, this should bring back the smoke tests.