Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2] Require span_count.started on transactions. #1351

Merged
merged 4 commits into from
Sep 11, 2018
Merged

[v2] Require span_count.started on transactions. #1351

merged 4 commits into from
Sep 11, 2018

Conversation

simitt
Copy link
Contributor

@simitt simitt commented Sep 3, 2018

implements #1241

@simitt simitt requested a review from roncohen September 3, 2018 14:33
@axw axw mentioned this pull request Sep 4, 2018
Closed
roncohen
roncohen reviewed Sep 4, 2018
View reviewed changes
docs/spec/transactions/v2_transaction.json Outdated
"properties": {
"total": {
"type": "integer",
"description": "Number of correlated spans that are recorded."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Number of correlated spans

I think "correlated" here is confusing.

@simitt simitt force-pushed the 1241-add-spancount branch from 584a3b1 to 67ffdec Compare September 4, 2018 12:17
@simitt simitt force-pushed the 1241-add-spancount branch from 67ffdec to c906cdc Compare September 4, 2018 13:41
@simitt
Copy link
Contributor Author

simitt commented Sep 4, 2018

jenkins, retest this please

@roncohen roncohen mentioned this pull request Sep 5, 2018
Closed
@simitt simitt changed the title [v2] Require span_count.total on transactions. [v2] Require span_count.started on transactions. Sep 11, 2018
@simitt simitt merged commit 1a3b2e4 into elastic:v2 Sep 11, 2018
roncohen pushed a commit to roncohen/apm-server that referenced this pull request Oct 7, 2018
@simitt
[v2] Change span_count on transactions. (elastic#1351)
d480fbf 
Require `transaction.span_count.started` on Intake API v2, not indexed in ES. 
Rename `transaction.span_count.dropped.total` to `transaction.span_count.dropped` on Intake API v2, leave unchanged in ES.

implements elastic#1241
roncohen pushed a commit to roncohen/apm-server that referenced this pull request Oct 15, 2018
@simitt
[v2] Change span_count on transactions. (elastic#1351)
a8e5041 
Require `transaction.span_count.started` on Intake API v2, not indexed in ES. 
Rename `transaction.span_count.dropped.total` to `transaction.span_count.dropped` on Intake API v2, leave unchanged in ES.

implements elastic#1241
roncohen pushed a commit to roncohen/apm-server that referenced this pull request Oct 15, 2018
@simitt
[v2] Change span_count on transactions. (elastic#1351)
b36a31f 
Require `transaction.span_count.started` on Intake API v2, not indexed in ES. 
Rename `transaction.span_count.dropped.total` to `transaction.span_count.dropped` on Intake API v2, leave unchanged in ES.

implements elastic#1241
roncohen pushed a commit to roncohen/apm-server that referenced this pull request Oct 15, 2018
@simitt
[v2] Change span_count on transactions. (elastic#1351)
6e29f4d 
Require `transaction.span_count.started` on Intake API v2, not indexed in ES. 
Rename `transaction.span_count.dropped.total` to `transaction.span_count.dropped` on Intake API v2, leave unchanged in ES.

implements elastic#1241
roncohen pushed a commit to roncohen/apm-server that referenced this pull request Oct 15, 2018
@simitt
[v2] Change span_count on transactions. (elastic#1351)
e0393e4 
Require `transaction.span_count.started` on Intake API v2, not indexed in ES. 
Rename `transaction.span_count.dropped.total` to `transaction.span_count.dropped` on Intake API v2, leave unchanged in ES.

implements elastic#1241
roncohen pushed a commit to roncohen/apm-server that referenced this pull request Oct 15, 2018
@simitt
[v2] Change span_count on transactions. (elastic#1351)
447b1b7 
Require `transaction.span_count.started` on Intake API v2, not indexed in ES. 
Rename `transaction.span_count.dropped.total` to `transaction.span_count.dropped` on Intake API v2, leave unchanged in ES.

implements elastic#1241
roncohen pushed a commit to roncohen/apm-server that referenced this pull request Oct 16, 2018
@simitt
[v2] Change span_count on transactions. (elastic#1351)
e770cb2 
Require `transaction.span_count.started` on Intake API v2, not indexed in ES. 
Rename `transaction.span_count.dropped.total` to `transaction.span_count.dropped` on Intake API v2, leave unchanged in ES.

implements elastic#1241
roncohen pushed a commit that referenced this pull request Oct 16, 2018
@simitt @roncohen
[v2] Change span_count on transactions. (#1351)
24081b4 
Require `transaction.span_count.started` on Intake API v2, not indexed in ES. 
Rename `transaction.span_count.dropped.total` to `transaction.span_count.dropped` on Intake API v2, leave unchanged in ES.

implements #1241
@simitt simitt deleted the 1241-add-spancount branch November 8, 2018 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roncohen roncohen roncohen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simitt @roncohen