Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert some flattened fields to object type #12157

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

axw
Copy link
Member

@axw axw commented Dec 5, 2023

Motivation/summary

Revert some fields from flattened back to object to align with how we will dynamically map those fields in the future. We keep a few APM-specific fields that may cause mapping conflicts as flattened for now.

Object-type fields:

  • http.request.env.*
  • http.request.cookies.*
  • http.request.headers.*
  • http.response.headers.*
  • span.message.headers.*
  • transaction.message.headers.*

Flattened-type fields:

  • error.custom (APM-specific arbitrary object structure)
  • error.exception.attributes (APM-specific arbitrary object structure)
  • error.exception.stacktrace (APM-specific structured stack trace)
  • error.log.stacktrace (APM-specific structured stack trace)
  • http.request.body (may be either a string or object, and object fields are arbitrary so therefore may cause conflicts)
  • span.stacktrace (APM-specific structured stack trace)
  • transaction.custom (APM-specific arbitrary object structure)

Checklist

- [ ] Update CHANGELOG.asciidoc
- [ ] Update package changelog.yml (only if changes to apmpackage have been made) (reverts an unreleased change made in #12102)
- [ ] Documentation has been updated

How to test these changes

  • Check that error/exception stack traces show up correctly in APM UI
  • Check that HTTP request/response headers show up in APM UI

Related issues

#11528
#11529

Revert some fields from flattened back to object to align
with how we will dynamically map those fields in the future.
We keep a few APM-specific fields that may cause mapping
conflicts as flattened for now.
@axw axw added the v8.12.0 label Dec 5, 2023
Copy link
Contributor

mergify bot commented Dec 5, 2023

This pull request does not have a backport label. Could you fix it @axw? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Dec 5, 2023
@axw axw marked this pull request as ready for review December 5, 2023 02:38
@axw axw requested a review from a team as a code owner December 5, 2023 02:38
@axw axw merged commit 0f7508b into elastic:main Dec 5, 2023
11 checks passed
@axw axw deleted the more-prep-apmdata branch December 5, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants