Update beats #1177
Update beats #1177
Conversation
docs/fields.asciidoc
Outdated
| @@ -1269,130 +1268,3 @@ Kubernetes container image | |||
|
|
|||
| -- | |||
|
|
|||
| [[exported-fields-system]] | |||
There was a problem hiding this comment.
Still wondering why this gets removed, but we can have a look as a follow-up task.
| @@ -0,0 +1,216 @@ | |||
|
|
|||
There was a problem hiding this comment.
This is not supposed to be committed right?
jalvz
force-pushed
the
update-beats
branch
2 times, most recently
from
729df54 to
8a6294b
Compare
|
jenkins retest this please |
| @@ -99,6 +99,10 @@ func Update() error { | |||
| return sh.Run("make", "update") | |||
| } | |||
|
|
|||
| func Fields() error { | |||
| return mage.GenerateFieldsYAML(".") | |||
There was a problem hiding this comment.
I think this should be model rather than ..
(I think the docs that I wrote in GenerateFieldsYAML are not 100% accurate w.r.t. how it searches for fields.yml files because I didn't fully understand the subtleties of how global_fields/main.go searches.)
There was a problem hiding this comment.
that won't skip _meta/fields.common.yml?
There was a problem hiding this comment.
_meta/fields.common.yml will still be included. The args to GenerateFieldsYAML are extra module directories to collect fields.yml.
There was a problem hiding this comment.
We will do a follow up fix then.
since they are not longer discovered
Follow up to PR elastic#1177
* Fix scripts for updating beats. Follow up to PR #1177 * Update beats framework to 2a3aabc
No description provided.