-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ecs.version
field from mappings
#11632
Conversation
This pull request does not have a backport label. Could you fix it @axw? 🙏
NOTE: |
8fd0c36
to
ab1f697
Compare
We don't use the field at all, and its presence works against converging on OTel SemConv, and decoupling the index templates from apm-server.
@@ -103,7 +103,7 @@ var observerIDsPipeline = []map[string]interface{}{{ | |||
}, | |||
}} | |||
|
|||
var ecsVersionPipeline = []map[string]interface{}{{ | |||
var removeECSVersionPipeline = []map[string]interface{}{{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, even the previous ecsVersionPipeline
was removing the field ecs.version
. Does this mean we were never indexing ecs.version
so it was not used in the mappings anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ingest pipeline was there to remove the field from documents written by older versions of apm-server. The field would get added back into documents as a constant_keyword
field.
I've left the removal there for now, but I don't think we'll keep that in elastic/elasticsearch#97546. We'll just dynamically map the field for older versions of apm-server - no big deal.
Motivation/summary
Remove the
ecs.version
field mapping from APM data streams. We don't use this field at all in APM UI, and its presence works against converging on OTel SemConv, and decoupling the index templates from apm-server.Checklist
apmpackage
have been made)- [ ] Documentation has been updatedHow to test these changes
apmtool
)ecs.version
field is not present in any APM docsRelated issues
elastic/elasticsearch#97546