Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update beats framework to fd9c363 #1163

Closed
wants to merge 3 commits into from
Closed

Update beats framework to fd9c363 #1163

wants to merge 3 commits into from

Conversation

roncohen
Copy link
Contributor

@roncohen roncohen commented Jul 19, 2018 •
edited by alvarolobato
Loading

Needed to backport #1137 amongst others

@jalvz
Copy link
Contributor

jalvz commented Jul 19, 2018

Beats merged elastic/beats@e80307a since we did the backport.

We have 2 mage copies, one in github.com/elastic/beats/dev-tools/mage, and that vendored in github.com/elastic/apm-server/vendor/github.com/elastic/beats/dev-tools/mage
First one you have it right, second one you have it wrong.

Shouldn't say const packageSpecFile = "dev-tools/mage/files/packages.yml"

@jalvz jalvz assigned jalvz and unassigned jalvz Jul 19, 2018
@jalvz jalvz self-requested a review July 23, 2018 06:40
@roncohen roncohen closed this Jul 23, 2018
@roncohen
Copy link
Contributor Author

trying this instead: #1167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalvz jalvz Awaiting requested review from jalvz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roncohen @jalvz