-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update beats #1053
Update beats #1053
Conversation
@andrewkroh thanks for explicitly testing the new packaging with APM, seems to work smoothly 👏 how do we use mage for the snapshot / release targets? |
I'm happy to help with any changes. Here's a summary of what I think needs to be done.
This enables Testing
External ChangesI would hold off on merging this in until after we have tested and verified everything with Beats. release-manager apm-server-docker
jenkins
|
62cd53b
to
df085e8
Compare
Many thanks @andrewkroh, done after some minor tweakings, tested the release targets as well and tried the darwin build. elastic/apm-server-docker#20 Anything else you found out lately? |
@simitt @graphaelli would be great if any of you has a look as well when you have some time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But I would rely more on CI's opinion 😄
We merged one more change to add DMG packaging, but I would add that in a separate update. It will require a small add to your customizePackaging()
method to overwrite the appropriate files inside the macos installer.
Makefile
Outdated
@@ -11,12 +10,10 @@ TEST_ENVIRONMENT=true | |||
ES_BEATS?=./_beats | |||
PREFIX?=. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think PREFIX is no longer used anywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from one minor comment LGTM afaict.
@@ -1,5 +1,4 @@ | |||
BEAT_NAME=apm-server | |||
BEAT_DESCRIPTION=Elastic Application Performance Monitoring Server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I saw this would be actually used in mage
. Where does the description now come from?
This update includes packaging refactor (elastic/beats#7388)
This causes make snapshot and make release to pull existing images from https://github.com/elastic/golang-crossbuild
This update includes packaging refactor (elastic/beats#7388)
required before #1010