Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update beats framework to d37c114 #1001

Merged
merged 3 commits into from
Jun 15, 2018
Merged

Update beats framework to d37c114 #1001

merged 3 commits into from
Jun 15, 2018

Conversation

jalvz
Copy link
Contributor

@jalvz jalvz commented Jun 12, 2018

No description provided.

@graphaelli
Copy link
Member

Can you add /*/_meta/kibana.generated to .gitignorefor this? Is there any other cleanup or documentation updated that needs to be done?

@jalvz
Copy link
Contributor Author

jalvz commented Jun 14, 2018

Thanks @graphaelli, can you have another look now?

graphaelli
graphaelli approved these changes Jun 14, 2018
View reviewed changes
Copy link
Member

@graphaelli graphaelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I like the docs updates coming in too - is that a 2nd step?

@jalvz jalvz merged commit 43ea772 into elastic:master Jun 15, 2018
@graphaelli graphaelli mentioned this pull request Jun 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphaelli graphaelli graphaelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jalvz @graphaelli