Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Starting APM Server with -environment container fails #3576

Closed
simitt opened this issue Mar 30, 2020 · 0 comments · Fixed by #3577
Closed

Starting APM Server with -environment container fails #3576

simitt opened this issue Mar 30, 2020 · 0 comments · Fixed by #3577
Labels
bug

Comments

@simitt
Copy link
Contributor

simitt commented Mar 30, 2020

Version: >= 7.7 branch

With introducing CLI flag -environment a new default value for logging to stdout/stderr was introduced. The new defaultToStderrConfig fails on decoding because the Files.FileConfig.MaxSize defaults to the zero value of 0, which conflicts with the required minimum value of 1.
This only concerns the APM Server as we overwrite logging defaults, leading to encoding logging.file to the zero value.

cc @kuisathaverat

How to reproduce: apm-server -environment container
@simitt simitt added the bug label Mar 30, 2020
simitt added a commit to simitt/apm-server that referenced this issue Mar 30, 2020
@simitt
[fix] fix logging overwrite values
c8e5620 
Ensure logging overwrites do not fail startup when passing in
-environment option

fixes elastic#3576
@simitt simitt mentioned this issue Mar 30, 2020
Merged
2 tasks
simitt added a commit that referenced this issue Mar 31, 2020
@simitt
[fix] fix logging overwrite values (#3577)
5c3a804 
Ensure logging overwrites do not fail startup when passing 
in -environment option

fixes #3576
simitt added a commit to simitt/apm-server that referenced this issue Mar 31, 2020
@simitt
[fix] fix logging overwrite values (elastic#3577)
038ad7d 
Ensure logging overwrites do not fail startup when passing 
in -environment option

fixes elastic#3576
simitt added a commit to simitt/apm-server that referenced this issue Mar 31, 2020
@simitt
[fix] fix logging overwrite values (elastic#3577)
ccaa960 
Ensure logging overwrites do not fail startup when passing 
in -environment option

fixes elastic#3576
simitt added a commit that referenced this issue Mar 31, 2020
@simitt
[fix] fix logging overwrite values (#3577) (#3580)
e8c71d9 
Ensure logging overwrites do not fail startup when passing 
in -environment option

fixes #3576
simitt added a commit that referenced this issue Mar 31, 2020
@simitt
[fix] fix logging overwrite values (#3577) (#3581)
72b30ff 
Ensure logging overwrites do not fail startup when passing 
in -environment option

fixes #3576
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix] fix logging overwrite values simitt/apm-server
1 participant
@simitt