Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2] adapt application metrics #1355

Closed
simitt opened this issue Sep 5, 2018 · 0 comments
Closed

[v2] adapt application metrics #1355

simitt opened this issue Sep 5, 2018 · 0 comments
Assignees
@simitt
Milestone
6.5

Comments

@simitt
Copy link
Contributor

simitt commented Sep 5, 2018

In v2 error responses are handled differently than in v1.
We have to adapt the collected metrics accordingly and ensure the semantics don't change and/or metrics are shown correctly in the monitoring tab.

see https://github.com/elastic/apm-server/blob/master/beater/handlers.go#L87
@roncohen roncohen mentioned this issue Sep 5, 2018
Closed
30 tasks
@simitt simitt mentioned this issue Sep 20, 2018
Merged
@simitt simitt self-assigned this Sep 21, 2018
simitt added a commit to simitt/apm-server that referenced this issue Sep 21, 2018
@simitt
[v2] Increase metrics counter in v2 responses.
537cfa1 
implements elastic#1355
@simitt simitt mentioned this issue Sep 21, 2018
Merged
simitt added a commit that referenced this issue Sep 24, 2018
@simitt
[v2] Add metrics counter handling for v2. (#1403)
9ffd1de 
implements #1355
@simitt simitt closed this as completed Sep 24, 2018
roncohen pushed a commit to roncohen/apm-server that referenced this issue Oct 7, 2018
@simitt
[v2] Add metrics counter handling for v2. (elastic#1403)
20cc669 
implements elastic#1355
roncohen pushed a commit to roncohen/apm-server that referenced this issue Oct 15, 2018
@simitt
[v2] Add metrics counter handling for v2. (elastic#1403)
f539431 
implements elastic#1355
roncohen pushed a commit to roncohen/apm-server that referenced this issue Oct 15, 2018
@simitt
[v2] Add metrics counter handling for v2. (elastic#1403)
0a1a437 
implements elastic#1355
roncohen pushed a commit to roncohen/apm-server that referenced this issue Oct 15, 2018
@simitt
[v2] Add metrics counter handling for v2. (elastic#1403)
cfce548 
implements elastic#1355
roncohen pushed a commit to roncohen/apm-server that referenced this issue Oct 15, 2018
@simitt
[v2] Add metrics counter handling for v2. (elastic#1403)
513c3c7 
implements elastic#1355
roncohen pushed a commit to roncohen/apm-server that referenced this issue Oct 15, 2018
@simitt
[v2] Add metrics counter handling for v2. (elastic#1403)
dc14710 
implements elastic#1355
roncohen pushed a commit to roncohen/apm-server that referenced this issue Oct 16, 2018
@simitt
[v2] Add metrics counter handling for v2. (elastic#1403)
3fe790a 
implements elastic#1355
roncohen pushed a commit that referenced this issue Oct 16, 2018
@simitt @roncohen
[v2] Add metrics counter handling for v2. (#1403)
8a9bae2 
implements #1355
@alvarolobato alvarolobato added this to the 6.5 milestone Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simitt simitt

Labels
None yet
Projects
None yet
Milestone
6.5
Development

No branches or pull requests
2 participants
@simitt @alvarolobato