fix-approvals

elastic · Nov 27, 2019 · 1d70cbf · 1d70cbf
1 parent 94192d6
commit 1d70cbf
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 3 deletions.
diff --git a/model/metadata/test_approved_system/transform_empty.approved.json b/model/metadata/test_approved_system/transform_empty.approved.json
@@ -0,0 +1 @@
+{}
diff --git a/model/metadata/test_approved_system/transform_empty_ip.approved.json b/model/metadata/test_approved_system/transform_empty_ip.approved.json
@@ -0,0 +1 @@
+{}
diff --git a/model/metadata/test_approved_system/transform_k8s_namespace.approved.json b/model/metadata/test_approved_system/transform_k8s_namespace.approved.json
@@ -0,0 +1 @@
+{}
diff --git a/model/metadata/test_approved_system/transform_k8s_podUID.approved.json b/model/metadata/test_approved_system/transform_k8s_podUID.approved.json
@@ -0,0 +1 @@
+{}
diff --git a/model/metadata/test_approved_system/transform_k8s_podname.approved.json b/model/metadata/test_approved_system/transform_k8s_podname.approved.json
@@ -0,0 +1 @@
+{}
diff --git a/tests/approvals/approvals.go b/tests/approvals/approvals.go
@@ -108,9 +108,7 @@ func Compare(path string, ignoredFields ...string) (map[string]interface{}, map[
 
 	var approved map[string]interface{}
 	approvedf, err := os.Open(path + ApprovedSuffix)
-	if err != nil {
-		approved = map[string]interface{}{}
-	} else {
+	if err == nil {
 		defer approvedf.Close()
 		if err := json.NewDecoder(approvedf).Decode(&approved); err != nil {
 			fmt.Println("Cannot unmarshal approved file ", path, err)