Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

ci: dockerLogs step #570

Merged
merged 5 commits into from
Jun 2, 2020
Merged

ci: dockerLogs step #570

merged 5 commits into from
Jun 2, 2020

Conversation

v1v
Copy link
Member

@v1v v1v commented Jun 2, 2020

What does this PR do?

This step will allow us to fulfil the below cases:

Given a docker/docker-compose provisioned Docker containers
When all the Docker containers are started
Then show the last log lines of each container
Given a docker/docker-compose provisioned Docker containers
When tests failed
Then show the last log lines of each container
And show the status of the Docker containers

Why is it important?

Reuse the same step across different projects that are already using it.

Related issues

Caused by elastic/apm-agent-rum-js#806
Used by:

Tasks

  • Add UTs
  • Add ITs if possible

Tests

  • Forcing a command failure with the flag failNever: true

image

  • Success build

image

@v1v v1v self-assigned this Jun 2, 2020
@v1v v1v added the automation label Jun 2, 2020
@botelastic botelastic bot added the groovy label Jun 2, 2020
@apmmachine
Copy link
Contributor

apmmachine commented Jun 2, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #570 updated]

  • Start Time: 2020-06-02T14:44:27.487+0000

  • Duration: 6 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 577
Skipped 8
Total 585

@botelastic botelastic bot added the master label Jun 2, 2020
@v1v v1v marked this pull request as ready for review June 2, 2020 13:57
@v1v v1v requested a review from a team June 2, 2020 13:57
@@ -0,0 +1,47 @@
#!/usr/bin/env bash
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This particular file was copied from https://github.com/elastic/apm-integration-testing/pull/848/files#diff-b9a5772126bdcf3f23e1ec67c1c88f55

I only added some header, fixed some shell-lint defects and added a minor condition regarding whether the docker-compose file exists.

Copy link
Contributor

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v1v v1v merged commit ecca55c into elastic:master Jun 2, 2020
@v1v v1v deleted the feature/docker-logs branch June 2, 2020 15:56
@v1v v1v added enhancement New feature or request and removed groovy master labels Jun 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants