Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

Build Kibana Docker Image Action #2348

Merged
merged 16 commits into from
Sep 12, 2023

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Sep 11, 2023

@kuisathaverat
Copy link
Contributor

kuisathaverat commented Sep 11, 2023

It probably fails, we are experiencing issues with building Kibana/main in the GitHub Action Runners, The issue looks like an OOM in Node.js. We have started using external runners for it.

@reakaleek reakaleek force-pushed the feature/build-and-publish-kibana-image-action branch from ecd70a3 to c94d97a Compare September 12, 2023 12:34
@reakaleek reakaleek marked this pull request as ready for review September 12, 2023 12:39
@reakaleek reakaleek requested a review from a team as a code owner September 12, 2023 12:39
@reakaleek reakaleek requested a review from v1v September 12, 2023 12:43
@reakaleek reakaleek marked this pull request as draft September 12, 2023 12:55
@reakaleek reakaleek marked this pull request as ready for review September 12, 2023 13:12
v1v
v1v previously approved these changes Sep 12, 2023
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with just a few comments

Comment on lines +53 to +57
## Outputs

| Name | Description |
|--------|-----------------------------------------------------|
| `ref` | The published docker image reference. (`image:tag`) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat!

.github/actions/kibana-docker-image/README.md Outdated Show resolved Hide resolved
.github/actions/kibana-docker-image/action.yml Outdated Show resolved Hide resolved
.github/actions/kibana-docker-image/action.yml Outdated Show resolved Hide resolved
Comment on lines +14 to +15
schedule:
- cron: '0 6 * * *'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great! So we can discover when things get broken

.github/workflows/test-kibana-docker-image-action.yml Outdated Show resolved Hide resolved
.github/workflows/test-kibana-docker-image-action.yml Outdated Show resolved Hide resolved
.github/workflows/test-kibana-docker-image-action.yml Outdated Show resolved Hide resolved
.github/workflows/test-kibana-docker-image-action.yml Outdated Show resolved Hide resolved
@reakaleek reakaleek merged commit 93eb34a into main Sep 12, 2023
@reakaleek reakaleek deleted the feature/build-and-publish-kibana-image-action branch September 12, 2023 13:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants