This repository has been archived by the owner on Oct 28, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Build Kibana Docker Image Action #2348
Merged
reakaleek
merged 16 commits into
main
from
feature/build-and-publish-kibana-image-action
Sep 12, 2023
Merged
Build Kibana Docker Image Action #2348
reakaleek
merged 16 commits into
main
from
feature/build-and-publish-kibana-image-action
Sep 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It probably fails, we are experiencing issues with building Kibana/main in the GitHub Action Runners, The issue looks like an OOM in Node.js. We have started using external runners for it. |
v1v
reviewed
Sep 12, 2023
.github/actions/build-and-publish-kibana-docker-image/action.yml
Outdated
Show resolved
Hide resolved
v1v
reviewed
Sep 12, 2023
.github/actions/build-and-publish-kibana-docker-image/action.yml
Outdated
Show resolved
Hide resolved
reakaleek
force-pushed
the
feature/build-and-publish-kibana-image-action
branch
from
September 12, 2023 12:34
ecd70a3
to
c94d97a
Compare
v1v
previously approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with just a few comments
Comment on lines
+53
to
+57
## Outputs | ||
|
||
| Name | Description | | ||
|--------|-----------------------------------------------------| | ||
| `ref` | The published docker image reference. (`image:tag`) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neat!
Comment on lines
+14
to
+15
schedule: | ||
- cron: '0 6 * * *' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great! So we can discover when things get broken
v1v
reviewed
Sep 12, 2023
reakaleek
commented
Sep 12, 2023
v1v
approved these changes
Sep 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR creates an action to build and push kibana docker images.
Tested in